Skip to content

fix: set page default to avoid change event on first render - #10605

Merged
web-padawan merged 2 commits into
mainfrom
fix/pdf-viewer-page-default
Nov 6, 2026
Merged

web-padawan merged 2 commits into
mainfrom
fix/pdf-viewer-page-default

Conversation

@vursen

@vursen vursen commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Description

Follow-up to #10523
Related to #10596

On the first render, the web component fires page-changed with its default of 1. The Flow client then syncs the property because the server holds no value for it, and the server fires a PageChangeEvent with isFromClient() returning true although the page did not change. Setting the page property to 1 in the PdfViewer constructor makes the client see the same value and skip the sync.

Type of change

  • Bugfix

vursen added a commit that referenced this pull request Nov 6, 2026
@vursen
vursen requested a review from web-padawan November 6, 2026 11:14

@vaadin-review-bot vaadin-review-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Nothing to flag — the changes look good.

@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

@web-padawan
web-padawan added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit f6758ac Nov 6, 2026
18 checks passed
@web-padawan
web-padawan deleted the fix/pdf-viewer-page-default branch November 6, 2026 11:41
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.4.0-alpha6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants