Repository navigation
fix: set page default to avoid change event on first render - #10605
Merged
Merged
Conversation
vursen
added a commit
that referenced
this pull request
Nov 6, 2026
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
|
web-padawan
approved these changes
Nov 6, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.4.0-alpha6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Follow-up to #10523
Related to #10596
On the first render, the web component fires
page-changedwith its default of1. The Flow client then syncs the property because the server holds no value for it, and the server fires aPageChangeEventwithisFromClient()returningtruealthough the page did not change. Setting thepageproperty to1in thePdfViewerconstructor makes the client see the same value and skip the sync.Type of change