Repository navigation
fix: implement equals and hashCode in map Coordinate - #10631
Merged
Merged
Conversation
Contributor
Author
|
Fixed both SonarCloud findings. The |
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
|
sissbruecker
approved these changes
Nov 10, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.4.0-alpha6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Coordinateis an immutable value class, but it did not overrideequalsorhashCode. Two instances with the same x and y were never equal, so they could not be found in aSet, used as map keys, or checked withcontains.Original contribution by
@jay23606in #10588 — thank you! This PR carries the same change over from that PR.Fixes #10586
What changed
Coordinate.equals(Object)now compares the x and y values usingDouble.compare.Coordinate.hashCode()is based on the same x and y values, so equal coordinates have equal hash codes.Test summary
nullor to an object of another type.