Skip to content

fix: allow partial I18N instances for Upload (#1906) (CP: 14.6) - #1931

Merged
sissbruecker merged 1 commit into
14.6from
cherry-pick-1906-to-14.6-1627370636186
Jul 27, 2021
Merged

sissbruecker merged 1 commit into
14.6from
cherry-pick-1906-to-14.6-1627370636186

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

* fix: allow partial I18N instances for Upload

* fix code style issues
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

SonarQube analysis reported 28 issues

  • MAJOR 11 major
  • MINOR 17 minor

Top 10 issues

  1. MAJOR Upload.java#L73: Either remove or fill this block of code. rule
  2. MAJOR Upload.java#L76: Either remove or fill this block of code. rule
  3. MAJOR Upload.java#L403: Remove this unused private "fireUploadInterrupted" method. rule
  4. MAJOR Upload.java#L625: Remove this unused private "getStringObject" method. rule
  5. MAJOR Upload.java#L636: Remove this unused private "getStringObject" method. rule
  6. MAJOR FileBufferView.java#L76: Define and throw a dedicated exception instead of using a generic one. rule
  7. MAJOR UploadTestsI18N.java#L25: Add a private constructor to hide the implicit public one. rule
  8. MAJOR UploadView.java#L56: Either log or rethrow this exception. rule
  9. MAJOR FileBufferView.java#L76: Define and throw a dedicated exception instead of using a generic one. rule
  10. MAJOR UploadTestsI18N.java#L25: Add a private constructor to hide the implicit public one. rule

@sissbruecker
sissbruecker merged commit e085d84 into 14.6 Jul 27, 2021
@sissbruecker
sissbruecker deleted the cherry-pick-1906-to-14.6-1627370636186 branch July 27, 2021 08:16
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with platform 14.6.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants