Skip to content

chore: add deprecated withEventHandler to LitRenderer - #2042

Merged
tomivirkki merged 4 commits into
masterfrom
litrenderer-witheventhandler
Aug 24, 2021
Merged

tomivirkki merged 4 commits into
masterfrom
litrenderer-witheventhandler

Conversation

@tomivirkki

@tomivirkki tomivirkki commented Aug 24, 2021 •

Copy link
Copy Markdown
Member

The primary purpose of this PR is to add a deprecated withEventHandler to the LitRenderer API to make the migrating experience from TemplateRenderer nicer:

Screenshot 2021-08-24 at 14 59 30

However, getEventHandlers() in LitRenderer currently throws an UnsupportedOperationException and using getFunctions() is recommended instead. Since neither of the getters really serve any purpose in the public renderer APIs, decided to

  1. remove getFunctions() completely
  2. keep the deprecated getEventHandlers() (updated the deprecation message, still throws an exception)

@tomivirkki tomivirkki added the no-polymer Removing Polymer from Vaadin public APIs label Aug 24, 2021
@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 16 issues

  • MAJOR 1 major
  • MINOR 12 minor
  • INFO 3 info

Top 10 issues

  1. MAJOR LitRenderer.java#L361: Add the missing @deprecated annotation. rule
  2. MINOR LitRenderer.java#L20: Remove this unused import 'java.util.Collections'. rule
  3. MINOR LitRenderer.java#L63: Rename this generic name to match the regular expression '^[A-Z][0-9]?$'. rule
  4. MINOR LitRenderer.java#L66: Make this final field static too. rule
  5. MINOR LitRenderer.java#L66: Rename this field "DEFAULT_RENDERER_NAME" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  6. MINOR LitRenderer.java#L73: Make this final field static too. rule
  7. MINOR LitRenderer.java#L73: Rename this field "ALPHANUMERIC_REGEX" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  8. MINOR LitRenderer.java#L75: Don't override a deprecated method or explicitly mark it as "@deprecated". rule
  9. MINOR LitRenderer.java#L83: Cast one of the operands of this addition operation to a "double". rule
  10. MINOR LitRenderer.java#L126: Rename this generic name to match the regular expression '^[A-Z][0-9]?$'. rule

@tomivirkki
tomivirkki enabled auto-merge (squash) August 24, 2021 14:25
@tomivirkki
tomivirkki merged commit bd38c3a into master Aug 24, 2021
@tomivirkki
tomivirkki deleted the litrenderer-witheventhandler branch August 24, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-polymer Removing Polymer from Vaadin public APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants