Skip to content

fix: change aria-multiselectable and aria-selected attributes in grid according to SelectionMode. - #2467

Merged
tomivirkki merged 9 commits into
masterfrom
grid/aria-tests
Jan 10, 2022
Merged

tomivirkki merged 9 commits into
masterfrom
grid/aria-tests

Conversation

@sosa-vaadin

Copy link
Copy Markdown
Contributor

Description

aria-multiselectable and aria-selected attributes must be added or removed from grid and its rows according to any user configuration and selection. These tests make sure they are.

Fixes vaadin/web-components#1536

@sosa-vaadin
sosa-vaadin requested a review from tomivirkki January 3, 2022 11:47
@sosa-vaadin sosa-vaadin changed the title chore: add tests to check for aria-multiselectable and aria-selected attributes in grid. fix: change aria-multiselectable and aria-selected attributes in grid according to SelectionMode. Jan 3, 2022
@tomivirkki
tomivirkki merged commit d4d675d into master Jan 10, 2022
@tomivirkki
tomivirkki deleted the grid/aria-tests branch January 10, 2022 08:51
@knoobie

knoobie commented Jan 20, 2022

Copy link
Copy Markdown
Contributor

I think this created a regression in one of my applications I'm currently migrating. In V22 there was no exception, but in V23.0.0.alpha2 there is - https://github.com/vaadin/flow/issues/12730

Do you want me to BFP it or something easy to fix?

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[grid] Wrong usage of aria-multiselectable & aria-selected

4 participants