Skip to content

feat: implement HasTheme for Map - #2694

Merged
DiegoCardoso merged 5 commits into
masterfrom
feat/map_implement_has_theme
Feb 22, 2022
Merged

DiegoCardoso merged 5 commits into
masterfrom
feat/map_implement_has_theme

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Description

Implements the HasTheme interface for the Map component.

Fixes #2693

Type of change

  • Feature

@DiegoCardoso DiegoCardoso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it also add a MapVariant enum with a BORDERLESS entry. Other components, such as Avatar and Crud have it, as well.

@sissbruecker
sissbruecker force-pushed the feat/map_implement_has_theme branch from 6c48399 to 685916b Compare February 21, 2022 15:14
@sissbruecker

Copy link
Copy Markdown
Member Author

@DiegoCardoso Added a variants enum and methods for adding / removing variants.

@DiegoCardoso DiegoCardoso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@DiegoCardoso
DiegoCardoso enabled auto-merge (squash) February 22, 2022 07:59
@DiegoCardoso
DiegoCardoso merged commit 27e513c into master Feb 22, 2022
@DiegoCardoso
DiegoCardoso deleted the feat/map_implement_has_theme branch February 22, 2022 08:01
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 290 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.beta4 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[map] Make Map component implement HasTheme

3 participants