Repository navigation
feat: implement HasTheme for Map - #2694
Merged
Merged
Conversation
DiegoCardoso
suggested changes
Feb 21, 2022
DiegoCardoso
left a comment
Contributor
There was a problem hiding this comment.
Should it also add a MapVariant enum with a BORDERLESS entry. Other components, such as Avatar and Crud have it, as well.
sissbruecker
force-pushed
the
feat/map_implement_has_theme
branch
from
February 21, 2022 15:14
6c48399 to
685916b
Compare
Member
Author
|
@DiegoCardoso Added a variants enum and methods for adding / removing variants. |
…-components into feat/map_implement_has_theme
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
This ticket/PR has been released with platform 23.0.0.beta4 and is also targeting the upcoming stable 23.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Implements the HasTheme interface for the Map component.
Fixes #2693
Type of change