Repository navigation
fix: re-enable lazy loading when reducing page size - #2744
Merged
Merged
Conversation
tomivirkki
approved these changes
Mar 2, 2022
Member
|
I also tested the new example with a very small page size (2) and it results in a similar issue = no items are loaded after a certain index and you get a warning saying This, however, isn't a component bug but rather an issue in DataCommunicator which limits the amount of fetched items depending on the page size used in the component. |
|
Kudos, SonarCloud Quality Gate passed!
|
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
* fix: re-enable lazy loading when reducing page size * fix combo box overlay sizing issues * run formatter * remove unused import Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
* fix: re-enable lazy loading when reducing page size * fix combo box overlay sizing issues * run formatter * remove unused import Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
sissbruecker
added a commit
that referenced
this pull request
Mar 2, 2022
* fix: re-enable lazy loading when reducing page size * fix combo box overlay sizing issues * run formatter * remove unused import Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com> Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com> Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
sissbruecker
added a commit
that referenced
this pull request
Mar 2, 2022
* fix: re-enable lazy loading when reducing page size * fix combo box overlay sizing issues * run formatter * remove unused import Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com> Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com> Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
sissbruecker
added a commit
that referenced
this pull request
Mar 3, 2022
* fix: re-enable lazy loading when reducing page size * fix combo box overlay sizing issues * run formatter * remove unused import Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com> (cherry picked from commit 1a5cb4f)
sissbruecker
added a commit
that referenced
this pull request
Mar 3, 2022
Collaborator
|
This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
The combo box connector has an internal mode where it disables lazy loading (or rather all data provider requests) if the page size is less than or equal the total number of items. This PR fixes a bug where reducing the page size would not disable that mode.
Fixes #2736
Type of change