Skip to content

fix: re-enable lazy loading when reducing page size - #2744

Merged
sissbruecker merged 6 commits into
masterfrom
fix/combo_box_reenable_lazy_loading
Mar 2, 2022
Merged

sissbruecker merged 6 commits into
masterfrom
fix/combo_box_reenable_lazy_loading

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Description

The combo box connector has an internal mode where it disables lazy loading (or rather all data provider requests) if the page size is less than or equal the total number of items. This PR fixes a bug where reducing the page size would not disable that mode.

Fixes #2736

Type of change

  • Bugfix

@tomivirkki

Copy link
Copy Markdown
Member

I also tested the new example with a very small page size (2) and it results in a similar issue = no items are loaded after a certain index and you get a warning saying Attempted to fetch more items from server than allowed in one go: number of items requested '22', maximum items allowed '20'

This, however, isn't a component bug but rather an issue in DataCommunicator which limits the amount of fetched items depending on the page size used in the component.

@sonarqubecloud

sonarqubecloud Bot commented Mar 2, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 309 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sissbruecker
sissbruecker merged commit 1a5cb4f into master Mar 2, 2022
@sissbruecker
sissbruecker deleted the fix/combo_box_reenable_lazy_loading branch March 2, 2022 11:23
vaadin-bot pushed a commit that referenced this pull request Mar 2, 2022
* fix: re-enable lazy loading when reducing page size

* fix combo box overlay sizing issues

* run formatter

* remove unused import

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
vaadin-bot pushed a commit that referenced this pull request Mar 2, 2022
* fix: re-enable lazy loading when reducing page size

* fix combo box overlay sizing issues

* run formatter

* remove unused import

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
sissbruecker added a commit that referenced this pull request Mar 2, 2022
* fix: re-enable lazy loading when reducing page size

* fix combo box overlay sizing issues

* run formatter

* remove unused import

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
sissbruecker added a commit that referenced this pull request Mar 2, 2022
* fix: re-enable lazy loading when reducing page size

* fix combo box overlay sizing issues

* run formatter

* remove unused import

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
sissbruecker added a commit that referenced this pull request Mar 3, 2022
* fix: re-enable lazy loading when reducing page size

* fix combo box overlay sizing issues

* run formatter

* remove unused import

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>

(cherry picked from commit 1a5cb4f)
sissbruecker added a commit that referenced this pull request Mar 3, 2022
* fix: re-enable lazy loading when reducing page size

* fix combo box overlay sizing issues

* run formatter

* remove unused import

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>

(cherry picked from commit 1a5cb4f)
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ComboBox doesn't fetch the next page

5 participants