Repository navigation
fix: don't throw on grid details cell focus - #2746
Merged
Merged
Conversation
web-padawan
approved these changes
Mar 2, 2022
sissbruecker
previously requested changes
Mar 2, 2022
sissbruecker
reviewed
Mar 2, 2022
| } | ||
|
|
||
| @Test | ||
| public void shouldNotThrowOnDetailsClick() { |
Member
There was a problem hiding this comment.
Not sure how valuable this test is. This kind of implies that someone would add back an exception, or that some other random error might occur at some point.
Member
Author
There was a problem hiding this comment.
Agreed, it's kind of an odd thing to test. This applies to pretty much every test in the repo that uses checkLogsForErrors().
Member
There was a problem hiding this comment.
Alright, just wanted to get your opinion on this
sissbruecker
approved these changes
Mar 2, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
sissbruecker
pushed a commit
that referenced
this pull request
Mar 2, 2022
sissbruecker
pushed a commit
that referenced
this pull request
Mar 2, 2022
sissbruecker
pushed a commit
that referenced
this pull request
Mar 2, 2022
Collaborator
|
This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Fixes #2727
This PR makes the connector not throw when a
cell-focusevent originates from "details" section.NOTE:
This is merely a bugfix to avoid the client-side exception, and doesn't add the missing support for details cell-focus events. Adding the missing feat is a separate topic and requires some design (for example, do we want to add "details" to the
GridSectionenum or use the existing "body" section withnullcolumn for details cell focus...)