Skip to content

fix: don't throw on grid details cell focus - #2746

Merged
tomivirkki merged 3 commits into
masterfrom
fix-details-focus-error
Mar 2, 2022
Merged

tomivirkki merged 3 commits into
masterfrom
fix-details-focus-error

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Fixes #2727

This PR makes the connector not throw when a cell-focus event originates from "details" section.

NOTE:
This is merely a bugfix to avoid the client-side exception, and doesn't add the missing support for details cell-focus events. Adding the missing feat is a separate topic and requires some design (for example, do we want to add "details" to the GridSection enum or use the existing "body" section with null column for details cell focus...)

@sissbruecker
sissbruecker dismissed their stale review March 2, 2022 10:30

Nevermind

}

@Test
public void shouldNotThrowOnDetailsClick() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how valuable this test is. This kind of implies that someone would add back an exception, or that some other random error might occur at some point.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, it's kind of an odd thing to test. This applies to pretty much every test in the repo that uses checkLogsForErrors().

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, just wanted to get your opinion on this

@sonarqubecloud

sonarqubecloud Bot commented Mar 2, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 309 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tomivirkki
tomivirkki merged commit ec2e035 into master Mar 2, 2022
@tomivirkki
tomivirkki deleted the fix-details-focus-error branch March 2, 2022 11:50
sissbruecker pushed a commit that referenced this pull request Mar 2, 2022
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
sissbruecker pushed a commit that referenced this pull request Mar 2, 2022
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
sissbruecker pushed a commit that referenced this pull request Mar 2, 2022
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking button in Details will cause JavaScript exception on console

4 participants