Skip to content

fix: clean confirm dialog slots before adding new content - #2754

Merged
tomivirkki merged 3 commits into
masterfrom
fix-confirm-dialog-add-to-slot
Mar 3, 2022
Merged

tomivirkki merged 3 commits into
masterfrom
fix-confirm-dialog-add-to-slot

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Fixes #2710

tomivirkki and others added 2 commits March 2, 2022 16:53
…ntegration-tests/src/main/java/com/vaadin/flow/component/confirmdialog/examples/FeaturesDiy.java

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
@sonarqubecloud

sonarqubecloud Bot commented Mar 2, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 374 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tomivirkki
tomivirkki merged commit 82cb762 into master Mar 3, 2022
@tomivirkki
tomivirkki deleted the fix-confirm-dialog-add-to-slot branch March 3, 2022 07:32
tomivirkki added a commit that referenced this pull request Mar 3, 2022
)

Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
tomivirkki added a commit that referenced this pull request Mar 3, 2022
)

Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
tomivirkki added a commit that referenced this pull request Mar 3, 2022
)

Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[confirm-dialog] Setting custom buttons keeps adding them instead of replacing them

3 participants