Skip to content

refactor!: remove fluent option APIs from Map - #2928

Merged
sissbruecker merged 5 commits into
masterfrom
refactor/remove_fluent_api_from_map
Mar 29, 2022
Merged

sissbruecker merged 5 commits into
masterfrom
refactor/remove_fluent_api_from_map

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Removes all fluent option APIs from the Map component. The fluent APIs required some workarounds for sub-classing, which were hard to follow and caused DX concerns. We will reconsider adding fluent APIs if better patterns emerge for implementing them in class hierarchies.

Closes #2849

Removes all fluent option APIs from the Map component. The fluent APIs required some workarounds for sub-classing, which were hard to follow and caused DX concerns. We will reconsider adding fluent APIs if better patterns emerge for implementing them in class hierarchies.

Closes #2849
@sissbruecker
sissbruecker requested a review from vursen March 23, 2022 09:22
sissbruecker added a commit to vaadin/docs that referenced this pull request Mar 23, 2022
vaadin/flow-components#2928 is going to introduce breaking changes to the Map component's API by removing all fluent option APIs. This PR updates the Map examples to remove usages of the fluent APIs in order to avoid compilation errors when the API change is released.
sissbruecker added a commit to vaadin/docs that referenced this pull request Mar 24, 2022
vaadin/flow-components#2928 is going to introduce breaking changes to the Map component's API by removing all fluent option APIs. This PR updates the Map examples to remove usages of the fluent APIs in order to avoid compilation errors when the API change is released.
@sissbruecker
sissbruecker requested a review from vursen March 24, 2022 18:20
@sissbruecker
sissbruecker enabled auto-merge (squash) March 29, 2022 16:25
@sissbruecker
sissbruecker merged commit 6ea45c9 into master Mar 29, 2022
@sissbruecker
sissbruecker deleted the refactor/remove_fluent_api_from_map branch March 29, 2022 16:32
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 874 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[map] Remove fluent APIs

3 participants