Repository navigation
refactor!: remove fluent option APIs from Map - #2928
Merged
Merged
Conversation
Removes all fluent option APIs from the Map component. The fluent APIs required some workarounds for sub-classing, which were hard to follow and caused DX concerns. We will reconsider adding fluent APIs if better patterns emerge for implementing them in class hierarchies. Closes #2849
sissbruecker
added a commit
to vaadin/docs
that referenced
this pull request
Mar 23, 2022
vaadin/flow-components#2928 is going to introduce breaking changes to the Map component's API by removing all fluent option APIs. This PR updates the Map examples to remove usages of the fluent APIs in order to avoid compilation errors when the API change is released.
sissbruecker
added a commit
to vaadin/docs
that referenced
this pull request
Mar 24, 2022
vaadin/flow-components#2928 is going to introduce breaking changes to the Map component's API by removing all fluent option APIs. This PR updates the Map examples to remove usages of the fluent APIs in order to avoid compilation errors when the API change is released.
vursen
requested changes
Mar 24, 2022
vursen
approved these changes
Mar 27, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Removes all fluent option APIs from the Map component. The fluent APIs required some workarounds for sub-classing, which were hard to follow and caused DX concerns. We will reconsider adding fluent APIs if better patterns emerge for implementing them in class hierarchies.
Closes #2849