Skip to content

fix: implement LitRenderer.getValueProviders - #3148

Merged
tomivirkki merged 2 commits into
masterfrom
lit-renderer-value-providers
May 10, 2022
Merged

tomivirkki merged 2 commits into
masterfrom
lit-renderer-value-providers

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Fixes #3086

The PR also deprecates the method in Renderer because value providers are not something each type of a Renderer necessarily has/uses (for example ComponentRenderer).

This PR also doesn't fix the bug mentioned in one of the comments on the issue (Grid.addColumn(renderer) doesn't automatically generate comparators for the value providers defined for the renderer). There's actually an old issue for it already and it should be resolved separately.

@tomivirkki
tomivirkki force-pushed the lit-renderer-value-providers branch from cb04325 to ce9e774 Compare May 10, 2022 08:35
@tomivirkki
tomivirkki merged commit ec55e86 into master May 10, 2022
@tomivirkki
tomivirkki deleted the lit-renderer-value-providers branch May 10, 2022 08:43
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 104 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LitRenderer getValueProviders returns an empty map even if ValueProviders have been added

2 participants