Repository navigation
fix: implement LitRenderer.getValueProviders - #3148
Merged
Merged
Conversation
web-padawan
approved these changes
May 10, 2022
tomivirkki
force-pushed
the
lit-renderer-value-providers
branch
from
May 10, 2022 08:35
cb04325 to
ce9e774
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
added a commit
that referenced
this pull request
May 10, 2022
tomivirkki
added a commit
that referenced
this pull request
May 10, 2022
tomivirkki
added a commit
that referenced
this pull request
May 10, 2022
tomivirkki
added a commit
that referenced
this pull request
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Fixes #3086
The PR also deprecates the method in
Rendererbecause value providers are not something each type of aRenderernecessarily has/uses (for exampleComponentRenderer).This PR also doesn't fix the bug mentioned in one of the comments on the issue (
Grid.addColumn(renderer)doesn't automatically generate comparators for the value providers defined for the renderer). There's actually an old issue for it already and it should be resolved separately.