Skip to content

refactor: improve performance of AbstractGridMultiSelectionModel#isSelected - #3167

Merged
sissbruecker merged 1 commit into
vaadin:masterfrom
datadobi:issue_3166
May 16, 2022
Merged

sissbruecker merged 1 commit into
vaadin:masterfrom
datadobi:issue_3166

Conversation

@pepijnve

@pepijnve pepijnve commented May 12, 2022 •

Copy link
Copy Markdown
Contributor

Description

Query the presence of the ID of the given item in the selected Map instead of iterating over the value set.
Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Closes #3166

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

vaadin#3166)

Query the presence of the ID of the given item in the `selected` Map instead of iterating over the value set.
@CLAassistant

CLAassistant commented May 12, 2022 •

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 115 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@sissbruecker sissbruecker changed the title fix: improve performance of AbstractGridMultiSelectionModel#isSelected refactor: improve performance of AbstractGridMultiSelectionModel#isSelected May 12, 2022
@sissbruecker

Copy link
Copy Markdown
Member

As this does not fix anything, I'm tagging this as a refactoring.

@pepijnve Please sign the CLA, so that we can accept the contribution.

@pepijnve

Copy link
Copy Markdown
Contributor Author

@sissbruecker done. I've integrated this in a local build already. That fixed the server side of things already; unfortunately I'm hitting the exact same performance problem on the client side now. See vaadin/web-components#3845

@sissbruecker
sissbruecker merged commit 4a3dde6 into vaadin:master May 16, 2022
vaadin-bot pushed a commit that referenced this pull request May 16, 2022
#3167)

Query the presence of the ID of the given item in the `selected` Map instead of iterating over the value set.
vaadin-bot pushed a commit that referenced this pull request May 16, 2022
#3167)

Query the presence of the ID of the given item in the `selected` Map instead of iterating over the value set.
web-padawan pushed a commit that referenced this pull request May 16, 2022
#3167) (#3189)

Query the presence of the ID of the given item in the `selected` Map instead of iterating over the value set.

Co-authored-by: Pepijn Van Eeckhoudt <pepijn@vaneeckhoudt.net>
web-padawan pushed a commit that referenced this pull request May 16, 2022
#3167) (#3188)

Query the presence of the ID of the given item in the `selected` Map instead of iterating over the value set.

Co-authored-by: Pepijn Van Eeckhoudt <pepijn@vaneeckhoudt.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve performance of AbstractGridMultiSelectionModel#isSelected

4 participants