Skip to content

feat: add setMultiSort override to provide priority - #3401

Merged
sissbruecker merged 4 commits into
masterfrom
feat/multi-sort-priority
Jul 5, 2022
Merged

sissbruecker merged 4 commits into
masterfrom
feat/multi-sort-priority

Conversation

@web-padawan

@web-padawan web-padawan commented Jun 27, 2022 •

Copy link
Copy Markdown
Member

Description

Fixes #1197

Type of change

  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@web-padawan
web-padawan force-pushed the feat/multi-sort-priority branch from d2e2831 to 1ca80bc Compare June 30, 2022 11:38
@web-padawan
web-padawan marked this pull request as ready for review June 30, 2022 11:38
@sonarqubecloud

sonarqubecloud Bot commented Jul 5, 2022

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 1 Security Hotspot
Code Smell A 4388 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker
sissbruecker merged commit 138bf33 into master Jul 5, 2022
@sissbruecker
sissbruecker deleted the feat/multi-sort-priority branch July 5, 2022 12:41
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grid Multisort behavior unintuitive

3 participants