Skip to content

feat: drop remove listener methods in favor of registrations - #3898

Merged
tomivirkki merged 2 commits into
masterfrom
feat/listener-registration
Oct 19, 2022
Merged

tomivirkki merged 2 commits into
masterfrom
feat/listener-registration

Conversation

@tomivirkki

@tomivirkki tomivirkki commented Oct 18, 2022 •

Copy link
Copy Markdown
Member

Description

This PR removes the empty event listener removal methods, such as removeSelectionChangeListener, and makes the related add listener methods return a Registration instead.

Type of change

  • Feature

@DiegoCardoso DiegoCardoso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* @return a {@link Registration} for removing the event listener
**/
public void addRowHeaderDoubleClickListener(
public Registration addRowHeaderDoubleClickListener(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we could move this method closer to the other listeners, maybe closer to the RowHeaderDoubleClickEvent declaration.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tomivirkki
tomivirkki enabled auto-merge (squash) October 19, 2022 07:20
@tomivirkki
tomivirkki disabled auto-merge October 19, 2022 07:20
@tomivirkki
tomivirkki enabled auto-merge (squash) October 19, 2022 07:21
@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 339 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomivirkki
tomivirkki merged commit 031f06f into master Oct 19, 2022
@tomivirkki
tomivirkki deleted the feat/listener-registration branch October 19, 2022 07:34
sissbruecker added a commit that referenced this pull request Oct 19, 2022
…3902)

Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants