Repository navigation
feat: drop remove listener methods in favor of registrations - #3898
Merged
Merged
Conversation
DiegoCardoso
approved these changes
Oct 19, 2022
| * @return a {@link Registration} for removing the event listener | ||
| **/ | ||
| public void addRowHeaderDoubleClickListener( | ||
| public Registration addRowHeaderDoubleClickListener( |
Contributor
There was a problem hiding this comment.
nit: we could move this method closer to the other listeners, maybe closer to the RowHeaderDoubleClickEvent declaration.
tomivirkki
enabled auto-merge (squash)
October 19, 2022 07:20
tomivirkki
disabled auto-merge
October 19, 2022 07:20
tomivirkki
enabled auto-merge (squash)
October 19, 2022 07:21
|
SonarCloud Quality Gate failed.
|
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
sissbruecker
added a commit
that referenced
this pull request
Oct 19, 2022
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Description
This PR removes the empty event listener removal methods, such as
removeSelectionChangeListener, and makes the related add listener methods return aRegistrationinstead.Type of change