Skip to content

fix: use Lumo colors for popup button overlay - #4269

Merged
tomivirkki merged 2 commits into
masterfrom
fix/spreadsheet-popup-background
Nov 30, 2022
Merged

tomivirkki merged 2 commits into
masterfrom
fix/spreadsheet-popup-background

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Description

Use Lumo colors for the popup button overlay

Fixes #4266

Before:

Screenshot 2022-11-30 at 13 39 53

After:

Screenshot 2022-11-30 at 13 37 54

Screenshot 2022-11-30 at 13 41 25

Type of change

Bugfix

border: none;
color: #474747;
outline: none;
background-color: initial;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dark mode colors also affected the function <input> field (shown in the first image)

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess Material theme would fall back to #fff as previously.

@tomivirkki

Copy link
Copy Markdown
Member Author

I guess Material theme would fall back to #fff as previously.

Yeah, that was the idea. Tested on Material also to make sure it works:

Screenshot 2022-11-30 at 14 24 08

@tomivirkki
tomivirkki enabled auto-merge (squash) November 30, 2022 12:26
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tomivirkki
tomivirkki merged commit f45181f into master Nov 30, 2022
@tomivirkki
tomivirkki deleted the fix/spreadsheet-popup-background branch November 30, 2022 12:59
tomivirkki added a commit that referenced this pull request Nov 30, 2022
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha6 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spreadsheet popup overlay background color is always white

3 participants