Repository navigation
fix: use Lumo colors for popup button overlay - #4269
Merged
Merged
Conversation
tomivirkki
commented
Nov 30, 2022
| border: none; | ||
| color: #474747; | ||
| outline: none; | ||
| background-color: initial; |
Member
Author
There was a problem hiding this comment.
The dark mode colors also affected the function <input> field (shown in the first image)
web-padawan
approved these changes
Nov 30, 2022
web-padawan
left a comment
Member
There was a problem hiding this comment.
LGTM. I guess Material theme would fall back to #fff as previously.
Member
Author
tomivirkki
enabled auto-merge (squash)
November 30, 2022 12:26
|
Kudos, SonarCloud Quality Gate passed! |
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
tomivirkki
added a commit
that referenced
this pull request
Nov 30, 2022
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.alpha6 and is also targeting the upcoming stable 24.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Description
Use Lumo colors for the popup button overlay
Fixes #4266
Before:
After:
Type of change
Bugfix