Skip to content

feat: spreadsheet custom components - #4349

Merged
ugur-vaadin merged 41 commits into
masterfrom
feat/spreadsheet-custom-components
Dec 16, 2022
Merged

ugur-vaadin merged 41 commits into
masterfrom
feat/spreadsheet-custom-components

Conversation

@ugur-vaadin

@ugur-vaadin ugur-vaadin commented Dec 13, 2022 •

Copy link
Copy Markdown
Contributor

Description

In Vaadin 8, Spreadsheet used to have custom component&editor support. This PR re-introduces this functionality to current version.

  • Use slot attribute for the custom component functionality.
  • Add test fixtures and tests for different editors and components.
  • Cleanup the legacy code related to this issue.

Fixes #3255
Part of vaadin/platform#3568

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@CLAassistant

CLAassistant commented Dec 13, 2022 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

}

spreadsheet.refreshAllCellValues();
private Object getCellValueForComponent(ComponentType componentType,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

21% of developers fix this issue

UnusedMethod: Method 'getCellValueForComponent' is never used.


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

ugur-vaadin and others added 5 commits December 13, 2022 14:49
@ugur-vaadin
ugur-vaadin marked this pull request as ready for review December 13, 2022 13:17

@tomivirkki tomivirkki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4349 (comment) still needs a fix

ugur-vaadin and others added 8 commits December 15, 2022 21:30
…tion-tests/src/main/java/com/vaadin/flow/component/spreadsheet/tests/fixtures/CustomComponentFixture.java

Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…tion-tests/src/main/java/com/vaadin/flow/component/spreadsheet/tests/PreserveOnRefreshPage.java

Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…tion-tests/src/main/java/com/vaadin/flow/component/spreadsheet/tests/fixtures/SimpleCustomEditorFixture.java

Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…tion-tests/src/main/java/com/vaadin/flow/component/spreadsheet/tests/PreserveOnRefreshPage.java

Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…tion-tests/src/main/java/com/vaadin/flow/component/spreadsheet/tests/fixtures/SimpleCustomEditorFixture.java

Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…tion-tests/src/main/java/com/vaadin/flow/component/spreadsheet/tests/fixtures/SimpleCustomEditorFixture.java

Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
@ugur-vaadin
ugur-vaadin enabled auto-merge (squash) December 16, 2022 14:08
@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 8 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 408 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha7 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[spreadsheet] CustomComponent feature is unimplemented

5 participants