Repository navigation
feat: spreadsheet custom components - #4349
Conversation
Add slot support for custom editors. Use element node ID instead of component ID for custom components.
| } | ||
|
|
||
| spreadsheet.refreshAllCellValues(); | ||
| private Object getCellValueForComponent(ComponentType componentType, |
There was a problem hiding this comment.
UnusedMethod: Method 'getCellValueForComponent' is never used.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
…tion-tests/src/main/java/com/vaadin/flow/component/spreadsheet/tests/fixtures/CustomComponentFixture.java Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…om/vaadin/flow-components into feat/spreadsheet-custom-components
tomivirkki
left a comment
There was a problem hiding this comment.
#4349 (comment) still needs a fix
…om/vaadin/flow-components into feat/spreadsheet-custom-components
…tion-tests/src/main/java/com/vaadin/flow/component/spreadsheet/tests/fixtures/CustomComponentFixture.java Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…tion-tests/src/main/java/com/vaadin/flow/component/spreadsheet/tests/PreserveOnRefreshPage.java Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…tion-tests/src/main/java/com/vaadin/flow/component/spreadsheet/tests/fixtures/SimpleCustomEditorFixture.java Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…tion-tests/src/main/java/com/vaadin/flow/component/spreadsheet/tests/PreserveOnRefreshPage.java Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…tion-tests/src/main/java/com/vaadin/flow/component/spreadsheet/tests/fixtures/SimpleCustomEditorFixture.java Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…tion-tests/src/main/java/com/vaadin/flow/component/spreadsheet/tests/fixtures/SimpleCustomEditorFixture.java Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
|
SonarCloud Quality Gate failed.
|
|
This ticket/PR has been released with Vaadin 24.0.0.alpha7 and is also targeting the upcoming stable 24.0.0 version. |










Description
In Vaadin 8,
Spreadsheetused to have custom component&editor support. This PR re-introduces this functionality to current version.slotattribute for the custom component functionality.Fixes #3255
Part of vaadin/platform#3568
Type of change
Checklist
Additional for
Featuretype of change