Repository navigation
refactor!: relocate Renderer API with custom function name - #4479
Merged
Merged
Conversation
tomivirkki
marked this pull request as draft
January 3, 2023 15:13
tomivirkki
marked this pull request as ready for review
January 4, 2023 07:24
DiegoCardoso
reviewed
Jan 4, 2023
DiegoCardoso
left a comment
Contributor
There was a problem hiding this comment.
GridPro has the class ColumnComponentPathRenderer, which extends ColumnPathRenderer. Should the signature of render be updated, so it will override the same method (render(Element container, DataKeyMapper<SOURCE> keyMapper, String rendererName))?
Member
Author
Probably cleaner that way. Done. |
DiegoCardoso
approved these changes
Jan 4, 2023
|
SonarCloud Quality Gate failed.
|
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.alpha8 and is also targeting the upcoming stable 24.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Description
Follow-up for #4224
Moves the
render(Element container, DataKeyMapper<SOURCE> keyMapper, String rendererName)API fromLitRenderertoRenderer. Every type ofRenderershould accept a custom name for the renderer function.Example:
Before the change,
Gridneeded to cast the renderer passed tosetItemDetailsRendereras aLitRendererto make it plug into therowDetailsRendererfunction on the Web Component. After the change, since the API is defined on theRenderer, casting is no longer necessary and anyRenderercan be passed as an item details renderer.Type of change