Skip to content

refactor!: remove renderer when setting item label generator - #4559

Merged
sissbruecker merged 2 commits into
masterfrom
refactor/checkbox_group_clear_renderer_when_setting_label_generator
Jan 19, 2023
Merged

sissbruecker merged 2 commits into
masterfrom
refactor/checkbox_group_clear_renderer_when_setting_label_generator

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Description

Changes CheckboxGroup to remove any previously set item renderer when setting an item label generator. This ensures that the item label generator is actually used after setting it, and aligns the behavior of the component with RadioButtonGroup.

Closes #4522

Type of change

  • Breaking change

@sissbruecker
sissbruecker force-pushed the refactor/checkbox_group_clear_renderer_when_setting_label_generator branch from 8818c99 to 0d703bd Compare January 19, 2023 10:25
@sissbruecker
sissbruecker enabled auto-merge (squash) January 19, 2023 12:02
@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 24 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker
sissbruecker merged commit 594ad48 into master Jan 19, 2023
@sissbruecker
sissbruecker deleted the refactor/checkbox_group_clear_renderer_when_setting_label_generator branch January 19, 2023 12:11
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting an item label generator in CheckboxGroup should override/remove any renderer

3 participants