Repository navigation
refactor!: remove renderer when setting item label generator - #4559
Merged
sissbruecker merged 2 commits intoJan 19, 2023
Merged
sissbruecker merged 2 commits into
sissbruecker merged 2 commits into
Conversation
sissbruecker
force-pushed
the
refactor/checkbox_group_clear_renderer_when_setting_label_generator
branch
from
January 19, 2023 10:25
8818c99 to
0d703bd
Compare
tomivirkki
reviewed
Jan 19, 2023
tomivirkki
approved these changes
Jan 19, 2023
…n_setting_label_generator
sissbruecker
enabled auto-merge (squash)
January 19, 2023 12:02
|
SonarCloud Quality Gate failed.
|
sissbruecker
deleted the
refactor/checkbox_group_clear_renderer_when_setting_label_generator
branch
January 19, 2023 12:11
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Description
Changes
CheckboxGroupto remove any previously set item renderer when setting an item label generator. This ensures that the item label generator is actually used after setting it, and aligns the behavior of the component withRadioButtonGroup.Closes #4522
Type of change