Skip to content

fix: check for null item in drag and drop filters - #5250

Merged
DiegoCardoso merged 4 commits into
mainfrom
fix/grid/check-null-drag-drop-filter
Jul 12, 2023
Merged

DiegoCardoso merged 4 commits into
mainfrom
fix/grid/check-null-drag-drop-filter

Conversation

@DiegoCardoso

Copy link
Copy Markdown
Contributor

Description

Fix the regression introduced by #5040 by adding a check for the item property in row in dragFilter and dropFilter methods. Sometimes the method can be invoked before item is defined for the row.

Fixes #5177

Type of change

  • Bugfix
  • Feature

@sissbruecker

Copy link
Copy Markdown
Member

Let's also set target labels to match the previous PR that introduced the regression.

@vursen

vursen commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

I'm currently checking if this issue is also caused by this regression. If that's the case, then the solution should probably be different.

@vursen

vursen commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

I'm currently checking if #5249 is also caused by this regression. If that's the case, then the solution should probably be different.

No, it's not. 👍

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DiegoCardoso

Copy link
Copy Markdown
Contributor Author

This seems to also fix #5192

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @DiegoCardoso and @DiegoCardoso, when i performed cherry-pick to this commit to 23.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 7d71bac
error: could not apply 7d71bac... fix: check for null item in drag and drop filters (#5250)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

DiegoCardoso added a commit that referenced this pull request Jul 12, 2023
DiegoCardoso added a commit that referenced this pull request Jul 12, 2023
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha4 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Grid] Cannot read properties of undefined (reading 'dragDisabled')

4 participants