Skip to content

fix: apply route parameters to side nav item correctly - #5253

Merged
ugur-vaadin merged 3 commits into
mainfrom
fix-apply-route-parameters-to-side-nav-item-correctly
Jul 13, 2023
Merged

ugur-vaadin merged 3 commits into
mainfrom
fix-apply-route-parameters-to-side-nav-item-correctly

Conversation

@ugur-vaadin

@ugur-vaadin ugur-vaadin commented Jul 12, 2023 •

Copy link
Copy Markdown
Contributor

Description

This PR

  • fixes the case where an alias does not require some of the provided route parameters, and therefore does not get added
  • adds tests for not adding aliases that have parameters that are not provided
  • expands the Side Nav Item route parameter tests with more aliases

No related issue.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@ugur-vaadin
ugur-vaadin marked this pull request as ready for review July 12, 2023 10:10
@ugur-vaadin
ugur-vaadin removed the request for review from vursen July 13, 2023 08:31
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ugur-vaadin
ugur-vaadin merged commit 0b2ee17 into main Jul 13, 2023
@ugur-vaadin
ugur-vaadin deleted the fix-apply-route-parameters-to-side-nav-item-correctly branch July 13, 2023 08:45
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha5 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants