Repository navigation
fix: add header and footer as virtual children - #5274
Merged
sissbruecker merged 3 commits intoJul 24, 2023
Merged
Conversation
Contributor
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
ugur-vaadin
marked this pull request as ready for review
July 20, 2023 22:03
sissbruecker
force-pushed
the
5263-dialog-add-header-footer-as-virtual-children
branch
from
July 24, 2023 08:08
55084f2 to
2b1bd0b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
sissbruecker
approved these changes
Jul 24, 2023
sissbruecker
deleted the
5263-dialog-add-header-footer-as-virtual-children
branch
July 24, 2023 08:25
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
* fix: add header and footer as virtual children * replace ITs with unit tests --------- Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
* fix: add header and footer as virtual children * replace ITs with unit tests --------- Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker
added a commit
that referenced
this pull request
Jul 24, 2023
sissbruecker
added a commit
that referenced
this pull request
Jul 24, 2023
Collaborator
|
This ticket/PR has been released with Vaadin 24.2.0.alpha5 and is also targeting the upcoming stable 24.2.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
When removing all the content from a dialog, it also removes the content of header and footer. They are there visually, but are not interactable. This PR adds the header and footer containers as virtual children to the dialog instead of directly adding them.
Fixes #5263
Type of change
Checklist