Skip to content

fix: add header and footer as virtual children - #5274

Merged
sissbruecker merged 3 commits into
mainfrom
5263-dialog-add-header-footer-as-virtual-children
Jul 24, 2023
Merged

sissbruecker merged 3 commits into
mainfrom
5263-dialog-add-header-footer-as-virtual-children

Conversation

@ugur-vaadin

Copy link
Copy Markdown
Contributor

Description

When removing all the content from a dialog, it also removes the content of header and footer. They are there visually, but are not interactable. This PR adds the header and footer containers as virtual children to the dialog instead of directly adding them.

Fixes #5263

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@sonatype-lift

sonatype-lift Bot commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@ugur-vaadin
ugur-vaadin marked this pull request as ready for review July 20, 2023 22:03
@sissbruecker
sissbruecker force-pushed the 5263-dialog-add-header-footer-as-virtual-children branch from 55084f2 to 2b1bd0b Compare July 24, 2023 08:08
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker
sissbruecker merged commit b2ac242 into main Jul 24, 2023
@sissbruecker
sissbruecker deleted the 5263-dialog-add-header-footer-as-virtual-children branch July 24, 2023 08:25
vaadin-bot pushed a commit that referenced this pull request Jul 24, 2023
* fix: add header and footer as virtual children

* replace ITs with unit tests

---------

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
vaadin-bot pushed a commit that referenced this pull request Jul 24, 2023
* fix: add header and footer as virtual children

* replace ITs with unit tests

---------

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker added a commit that referenced this pull request Jul 24, 2023
* fix: add header and footer as virtual children

* replace ITs with unit tests

---------

Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker added a commit that referenced this pull request Jul 24, 2023
* fix: add header and footer as virtual children

* replace ITs with unit tests

---------

Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha5 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling Dialog::removeAll destroys interaction with header and footer of a dialog

3 participants