Repository navigation
fix: access UI through container element in ComponentRenderer - #6759
Conversation
5e2ded3 to
c4d8969
Compare
c4d8969 to
3fc33e1
Compare
| } | ||
|
|
||
| @Test | ||
| public void addComponentRendererBeforeAttach_componentIsRendered() { |
There was a problem hiding this comment.
note: This is a modern version of the previous test which covered #5534
|
|
Hi @vursen and @vursen, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually? |
|
This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version. |



Description
Using
UI.getCurrent()isn't safe because even when the container is attached, it may returnnull. This PR updates the ComponentRenderer implementation to access the UI instance through the container element where it's guaranteed to be available if the container is attached.Fixes #6751
Type of change