Skip to content

refactor!: remove LUMO_ICON_ON_TOP theme variant from TabSheet and Tabs - #7980

Merged
sissbruecker merged 4 commits into
mainfrom
refactor/remove-icons-on-top-variant
Sep 9, 2025
Merged

sissbruecker merged 4 commits into
mainfrom
refactor/remove-icons-on-top-variant

Conversation

@sissbruecker

@sissbruecker sissbruecker commented Sep 9, 2025 •

Copy link
Copy Markdown
Member

Description

Removes the deprecated TabSheetVariant.LUMO_ICON_ON_TOP and TabsVariant.LUMO_ICON_ON_TOP theme variants in v25.

Fixes #6652

Type of change

  • Breaking change

@ugur-vaadin

Copy link
Copy Markdown
Contributor

Should we also remove TabsVariant.LUMO_ICON_ON_TOP?

@sissbruecker

Copy link
Copy Markdown
Member Author

Apparently yes, thanks.

@sissbruecker sissbruecker changed the title refactor!: remove TabSheetVariant.LUMO_ICON_ON_TOP refactor!: remove LUMO_ICON_ON_TOP theme variant from TabSheet and Tabs Sep 9, 2025
@sissbruecker
sissbruecker enabled auto-merge (squash) September 9, 2025 11:48
@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2025

Copy link
Copy Markdown

@sissbruecker
sissbruecker merged commit c000c06 into main Sep 9, 2025
@sissbruecker
sissbruecker deleted the refactor/remove-icons-on-top-variant branch September 9, 2025 11:59
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.0.0-alpha10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove TabSheetVariant.LUMO_TABS_ICON_ON_TOP

4 participants