Skip to content

refactor!: expand on scroll to index and throw if not found - #8109

Merged
ugur-vaadin merged 44 commits into
mainfrom
refactor-expand-on-scroll-to-index-and-throw-if-not-found
Oct 3, 2025
Merged

ugur-vaadin merged 44 commits into
mainfrom
refactor-expand-on-scroll-to-index-and-throw-if-not-found

Conversation

@ugur-vaadin

Copy link
Copy Markdown
Contributor

Description

This PR updates TreeGrid.scrollToIndex methods so that:

  • No scrolling occurs and an IllegalArgumentException is thrown if the corresponding item is not found
  • Expands the parents in the path if the nested path contains collapsed parents

A follow-up to #8070.

Warning

This PR is a behaviour breaking change.

Type of change

  • Bugfix
  • Feature
  • Refactor

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@ugur-vaadin
ugur-vaadin requested a review from vursen October 1, 2025 16:27
@ugur-vaadin
ugur-vaadin marked this pull request as ready for review October 1, 2025 16:27
@ugur-vaadin
ugur-vaadin force-pushed the experiment-add-scrolltoitem-for-treedataproviders branch 3 times, most recently from 7248daa to a476083 Compare October 3, 2025 10:30
@ugur-vaadin
ugur-vaadin changed the base branch from experiment-add-scrolltoitem-for-treedataproviders to main October 3, 2025 11:17
@ugur-vaadin
ugur-vaadin changed the base branch from main to experiment-add-scrolltoitem-for-treedataproviders October 3, 2025 11:17
@ugur-vaadin
ugur-vaadin force-pushed the refactor-expand-on-scroll-to-index-and-throw-if-not-found branch from 2985cf5 to 43b2370 Compare October 3, 2025 11:20
Base automatically changed from experiment-add-scrolltoitem-for-treedataproviders to main October 3, 2025 11:24
@ugur-vaadin
ugur-vaadin force-pushed the refactor-expand-on-scroll-to-index-and-throw-if-not-found branch from 81bc6d5 to 087776c Compare October 3, 2025 11:39
@ugur-vaadin
ugur-vaadin enabled auto-merge (squash) October 3, 2025 12:32
@ugur-vaadin
ugur-vaadin disabled auto-merge October 3, 2025 12:36
@sonarqubecloud

sonarqubecloud Bot commented Oct 3, 2025

Copy link
Copy Markdown

@ugur-vaadin
ugur-vaadin merged commit c22b953 into main Oct 3, 2025
4 checks passed
@ugur-vaadin
ugur-vaadin deleted the refactor-expand-on-scroll-to-index-and-throw-if-not-found branch October 3, 2025 14:10
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.0.0-alpha14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants