Skip to content

fix: auto-attach Popover based on helper annotation (#8110) (CP: 24.9) - #8132

Merged
DiegoCardoso merged 2 commits into
24.9from
cp/popover/auto-attach-24.9
Oct 7, 2025
Merged

DiegoCardoso merged 2 commits into
24.9from
cp/popover/auto-attach-24.9

Conversation

@DiegoCardoso

Copy link
Copy Markdown
Contributor

Description

Cherry-pick from #8110 to V24.9

Type of change

  • Cherry-pick

Introduces a new internal Java annotation interface to help Popover
decide where to attach itself when the component is auto added to the
UI. Adds the `@ModalComponent` annotation to the following components:
- Dialog
- ConfirmDialog
- LoginOverlay

When the Popover target's element is inside any of the components above,
the component will be placed in the same parent as the target's to allow
events to be listened from the Popover content.
@DiegoCardoso
DiegoCardoso enabled auto-merge (squash) October 7, 2025 12:47
@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2025

Copy link
Copy Markdown

@DiegoCardoso
DiegoCardoso merged commit 3cd3a67 into 24.9 Oct 7, 2025
4 checks passed
@DiegoCardoso
DiegoCardoso deleted the cp/popover/auto-attach-24.9 branch October 7, 2025 14:16
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.9.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants