Skip to content

feat: add IntegerSlider, IntegerRangeSlider - #9123

Merged
sissbruecker merged 4 commits into
mainfrom
feat/integer-slider
Apr 15, 2026
Merged

sissbruecker merged 4 commits into
mainfrom
feat/integer-slider

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Description

Adds IntegerSlider and IntegerRangeSlider as alternative slider variants that use integer values for min, max, step and value properties.

Also adds IntegerSliderElement and IntegerRangeSliderElement TestBench elements for convenience.

Part of #8863

Type of change

  • Feature

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For unit tests, I only added new suites for the basic properties of IntegerSlider and IntegerRangeSlider. Duplicating the other suites seemed a bit much and making them generic is also not trivial.

For integration tests I duplicated the existing ones. There weren't a lot of them and it seemed valuable to have an E2E test for the new variants.

@sissbruecker
sissbruecker marked this pull request as ready for review April 15, 2026 12:01
@sissbruecker
sissbruecker requested a review from vursen April 15, 2026 12:01
…a/com/vaadin/flow/component/slider/testbench/NumberRangeSliderElement.java

Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sissbruecker
sissbruecker added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit e3a9f62 Apr 15, 2026
8 of 9 checks passed
@sissbruecker
sissbruecker deleted the feat/integer-slider branch April 15, 2026 14:33
mcollovati pushed a commit to vaadin/browserless-test that referenced this pull request Apr 17, 2026
vaadin/flow-components#9123 added the
`IntegerSlider` / `IntegerRangeSlider` variants. This adds respective
testers for the new component.

To reuse existing logic, this extracts abstract / generic
`NumberSliderTester` / `NumberRangeSliderTester` component testers and
bases the existing and new testers on top of them.

As a side-effect, getters and setters now use boxed values. This is a
breaking change. We deem that acceptable as the Slider component is
still considered experimental and is behind a feature flag.

Part of vaadin/flow-components#8863

Fixes #36
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.2.0-alpha3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants