Skip to content

Using parent theme from jar dependency in development mode fails build. #11152

Closed

Description

@caalador

Running a project in development mode with an external parent theme fails the webpack build with:

[ForkJoinPool.commonPool-worker-9] INFO com.vaadin.base.devserver.DevModeHandlerImpl - Running webpack to compile frontend resources. This may take a moment, please stand by...
C:\Users\mikae\Code\flow\flow-tests\test-application-theme\test-reusable-as-parent\target\plugins\application-theme-plugin\theme-handle.js:225
          throw new Error("Could not locate files for defined parent theme '" + themeProperties.parent + "'.\n" +
          ^

Error: Could not locate files for defined parent theme 'reusable-theme'.
Please verify that dependency is added or theme folder exists.
    at C:\Users\mikae\Code\flow\flow-tests\test-application-theme\test-reusable-as-parent\target\plugins\application-theme-plugin\theme-handle.js:225:17

as the folder the parent theme is copied to is in target which is not watched.

To test the issue run flow-tests\test-application-theme\test-reusable-as-parent in development mode by adding the vaadin-dev-server dependency and setting the plugin to only run prepare-frontend. then start project with mvn package jetty:run

This is a regression from #10834

Activity

  1. rolfsmeds commented on Jun 4, 2021

    @rolfsmeds

    This makes it virtually impossible to use external themes with app projects generated with Start, as those contain their own themes that supply the required css, so you can't just replace that with an external theme without first copying all the bunded css to that custom theme (and without that bundled css the views based on Start templates don't work properly).

    The same problem applies to Publisher, as the Vaadin project that is used for the docs also has its own theme supplying various examples with the css they need.

  2. self-assigned this
    on Jun 9, 2021
  3. jouni commented on Jun 9, 2021

    @jouni
    Member

    We have a design system customer case that will be partially blocked/handicapped by this issue.

  4. added a commit that references this issue on Jun 17, 2021
    7401a5a
  5. added 4 commits that reference this issue on Jun 17, 2021
    ec78289
    9399fab
    ff0da35
    df532b9
  6. added a commit that references this issue on Jun 17, 2021
    b01dc98
  7. added a commit that references this issue on Jun 17, 2021
    07722e4
  8. added 2 commits that reference this issue on Jun 17, 2021
    6427478
    2ffe00f
  9. vaadin-bot commented on Jun 21, 2021

    @vaadin-bot
    Collaborator

    This ticket/PR has been released with platform 21.0.0.alpha7. For prerelease versions, it will be included in its final version.

  10. vaadin-bot commented on Jun 23, 2021

    @vaadin-bot
    Collaborator

    This ticket/PR has been released with platform 14.6.4. For prerelease versions, it will be included in its final version.

  11. vaadin-bot commented on Aug 9, 2021

    @vaadin-bot
    Collaborator

    This ticket/PR has been released with platform 14.7.0.alpha3 and is also targeting the upcoming stable 14.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions