Repository navigation
Description
Description of the bug
The frontend compilation of a new project downloaded from start.vaadin.com fails if one first runs npm install, then runs mvn.
The following error is displayed:
------------------ Starting Frontend compilation. ------------------
2022-03-08 09:13:36.429 INFO 24496 --- [onPool-worker-1] c.v.b.devserver.AbstractDevServerRunner : Running Webpack to compile frontend resources. This may take a moment, please stand by...
2022-03-08 09:13:38.483 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : [webpack-cli] Failed to load 'C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\webpack.config.js' config
2022-03-08 09:13:38.485 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : [webpack-cli] Error: Cannot find module '@vaadin/build-status-plugin'
2022-03-08 09:13:38.485 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : Require stack:
2022-03-08 09:13:38.486 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : - C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\webpack.generated.js
2022-03-08 09:13:38.486 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : - C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\webpack.config.js
2022-03-08 09:13:38.486 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : - C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\node_modules\webpack-cli\lib\webpack-cli.js
2022-03-08 09:13:38.486 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : - C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\node_modules\webpack-cli\lib\bootstrap.js
2022-03-08 09:13:38.486 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : - C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\node_modules\webpack-cli\bin\cli.js
2022-03-08 09:13:38.486 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : - C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\node_modules\webpack-dev-server\bin\webpack-dev-server.js
2022-03-08 09:13:38.486 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
2022-03-08 09:13:38.486 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : at Function.Module._load (node:internal/modules/cjs/loader:778:27)
2022-03-08 09:13:38.486 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : at Module.require (node:internal/modules/cjs/loader:999:19)
2022-03-08 09:13:38.486 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : at require (node:internal/modules/cjs/helpers:102:18)
2022-03-08 09:13:38.486 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : at Object.<anonymous> (C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\webpack.generated.js:16:27)
2022-03-08 09:13:38.486 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : at Module._compile (node:internal/modules/cjs/loader:1097:14)
2022-03-08 09:13:38.487 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : at Object.Module._extensions..js (node:internal/modules/cjs/loader:1149:10)
2022-03-08 09:13:38.487 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : at Module.load (node:internal/modules/cjs/loader:975:32)
2022-03-08 09:13:38.487 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : at Function.Module._load (node:internal/modules/cjs/loader:822:12)
2022-03-08 09:13:38.487 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : at Module.require (node:internal/modules/cjs/loader:999:19) {
2022-03-08 09:13:38.487 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : code: 'MODULE_NOT_FOUND',
2022-03-08 09:13:38.487 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : requireStack: [
2022-03-08 09:13:38.487 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : 'C:\\Users\\Tarek Oraby\\Downloads\\my-app - 2022-03-08T091128.488\\my-app\\webpack.generated.js',
2022-03-08 09:13:38.487 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : 'C:\\Users\\Tarek Oraby\\Downloads\\my-app - 2022-03-08T091128.488\\my-app\\webpack.config.js',
2022-03-08 09:13:38.487 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : 'C:\\Users\\Tarek Oraby\\Downloads\\my-app - 2022-03-08T091128.488\\my-app\\node_modules\\webpack-cli\\lib\\webpack-cli.js',
2022-03-08 09:13:38.487 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : 'C:\\Users\\Tarek Oraby\\Downloads\\my-app - 2022-03-08T091128.488\\my-app\\node_modules\\webpack-cli\\lib\\bootstrap.js',
2022-03-08 09:13:38.487 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : 'C:\\Users\\Tarek Oraby\\Downloads\\my-app - 2022-03-08T091128.488\\my-app\\node_modules\\webpack-cli\\bin\\cli.js',
2022-03-08 09:13:38.487 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : 'C:\\Users\\Tarek Oraby\\Downloads\\my-app - 2022-03-08T091128.488\\my-app\\node_modules\\webpack-dev-server\\bin\\webpack-dev-server.js'
2022-03-08 09:13:38.487 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : ]
2022-03-08 09:13:38.488 INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker : }
Expected behavior
No error is shown.
Minimal reproducible example
- Download a project from start.vaadin.com
- from the terminal, run
npm install - run
mvn
NOTE: the error will be shown only on the first run of mvn. In subsequent runs, frontend compilation completes just fine.
Versions
- Vaadin / Flow version: 23.0.0
- Java version: 17
- OS version: Windows
Activity
Artur- commentedon Mar 8, 2022
Cannot reproduce
Starts fine
Artur- commentedon Mar 8, 2022
The original case would happen if
mvnwould not runnpm installbut it does. It would be unexpected if it does not aspackage.jsondoes not have a hash matching one innode_modulescaalador commentedon Mar 8, 2022
The only issue that I noted is that the project from start contains in package.json the plugin mentions and
npm iwill then generatetarget/plugins/...folders which are empty and on the first mvn execution these were for some reason not populated even though they should always be copied.Then again what is the use of running
npm imanually for flow when the use case of flow is to abstract and handle this automatically? Also Flow will in any case executenpm ias the hash will be missing.Artur- commentedon Mar 8, 2022
"npm i" can be run automatically by the IDE in some cases. Either after asking the user or automatically
caalador commentedon Mar 8, 2022
I just noted that the plugin files are copied to target, but something deletes them from the directories making the initial mvn execution fail. I expect that this has at least to a part something to do with the problem of symlinks in windows and not following and deleting the actual files that are linked. see #11177
Artur- commentedon Mar 8, 2022
Could we just publish the plugins to npm for real?
caalador commentedon Mar 8, 2022
I would rather they were used as scripts and not have them handled through npm at all.
fix: Don't use plugins through npm
fix: Don't use plugins through npm
fix: Don't use plugins through npm (#13254)
fix: Don't use plugins through npm (#13254)
fix: Don't use plugins through npm (#13254) (#13289)
vaadin-bot commentedon Mar 28, 2022
This ticket/PR has been released with Vaadin 23.0.3.
tarekoraby commentedon Mar 29, 2022
The issue is still present in 23.0.3. I just replicated it by running
npm installon the skeleton-starter-flow-spring project, followed bymvn.fix: clean and do not add plugins
fix: clean and do not add plugins (#13386)
fix: clean and do not add plugins (#13386)
fix: clean and do not add plugins (#13386) (#13392)