Skip to content

Frontend compilation fails after manual npm install #13247

Description

@tarekoraby

Description of the bug

The frontend compilation of a new project downloaded from start.vaadin.com fails if one first runs npm install, then runs mvn.

The following error is displayed:

------------------ Starting Frontend compilation. ------------------
2022-03-08 09:13:36.429  INFO 24496 --- [onPool-worker-1] c.v.b.devserver.AbstractDevServerRunner  : Running Webpack to compile frontend resources. This may take a moment, please stand by...
2022-03-08 09:13:38.483  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   : [webpack-cli] Failed to load 'C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\webpack.config.js' config
2022-03-08 09:13:38.485  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   : [webpack-cli] Error: Cannot find module '@vaadin/build-status-plugin'
2022-03-08 09:13:38.485  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   : Require stack:
2022-03-08 09:13:38.486  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   : - C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\webpack.generated.js
2022-03-08 09:13:38.486  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   : - C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\webpack.config.js
2022-03-08 09:13:38.486  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   : - C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\node_modules\webpack-cli\lib\webpack-cli.js
2022-03-08 09:13:38.486  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   : - C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\node_modules\webpack-cli\lib\bootstrap.js
2022-03-08 09:13:38.486  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   : - C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\node_modules\webpack-cli\bin\cli.js
2022-03-08 09:13:38.486  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   : - C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\node_modules\webpack-dev-server\bin\webpack-dev-server.js
2022-03-08 09:13:38.486  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
2022-03-08 09:13:38.486  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     at Function.Module._load (node:internal/modules/cjs/loader:778:27)
2022-03-08 09:13:38.486  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     at Module.require (node:internal/modules/cjs/loader:999:19)
2022-03-08 09:13:38.486  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     at require (node:internal/modules/cjs/helpers:102:18)
2022-03-08 09:13:38.486  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     at Object.<anonymous> (C:\Users\Tarek Oraby\Downloads\my-app - 2022-03-08T091128.488\my-app\webpack.generated.js:16:27)
2022-03-08 09:13:38.486  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     at Module._compile (node:internal/modules/cjs/loader:1097:14)
2022-03-08 09:13:38.487  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1149:10)
2022-03-08 09:13:38.487  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     at Module.load (node:internal/modules/cjs/loader:975:32)
2022-03-08 09:13:38.487  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     at Function.Module._load (node:internal/modules/cjs/loader:822:12)
2022-03-08 09:13:38.487  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     at Module.require (node:internal/modules/cjs/loader:999:19) {
2022-03-08 09:13:38.487  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :   code: 'MODULE_NOT_FOUND',
2022-03-08 09:13:38.487  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :   requireStack: [
2022-03-08 09:13:38.487  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     'C:\\Users\\Tarek Oraby\\Downloads\\my-app - 2022-03-08T091128.488\\my-app\\webpack.generated.js',
2022-03-08 09:13:38.487  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     'C:\\Users\\Tarek Oraby\\Downloads\\my-app - 2022-03-08T091128.488\\my-app\\webpack.config.js',
2022-03-08 09:13:38.487  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     'C:\\Users\\Tarek Oraby\\Downloads\\my-app - 2022-03-08T091128.488\\my-app\\node_modules\\webpack-cli\\lib\\webpack-cli.js',
2022-03-08 09:13:38.487  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     'C:\\Users\\Tarek Oraby\\Downloads\\my-app - 2022-03-08T091128.488\\my-app\\node_modules\\webpack-cli\\lib\\bootstrap.js',
2022-03-08 09:13:38.487  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     'C:\\Users\\Tarek Oraby\\Downloads\\my-app - 2022-03-08T091128.488\\my-app\\node_modules\\webpack-cli\\bin\\cli.js',
2022-03-08 09:13:38.487  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     'C:\\Users\\Tarek Oraby\\Downloads\\my-app - 2022-03-08T091128.488\\my-app\\node_modules\\webpack-dev-server\\bin\\webpack-dev-server.js'
2022-03-08 09:13:38.487  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :   ]
2022-03-08 09:13:38.488  INFO 24496 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   : }

Expected behavior

No error is shown.

Minimal reproducible example

  1. Download a project from start.vaadin.com
  2. from the terminal, run npm install
  3. run mvn

NOTE: the error will be shown only on the first run of mvn. In subsequent runs, frontend compilation completes just fine.

Versions

  • Vaadin / Flow version: 23.0.0
  • Java version: 17
  • OS version: Windows

Activity

  1. Artur- commented on Mar 8, 2022

    @Artur-
    Member

    Cannot reproduce

    vaadin init test-npm
    cd test-npm
    npm install
    mvn
    

    Starts fine

  2. Artur- commented on Mar 8, 2022

    @Artur-
    Member

    The original case would happen if mvn would not run npm install but it does. It would be unexpected if it does not as package.json does not have a hash matching one in node_modules

  3. caalador commented on Mar 8, 2022

    @caalador
    Contributor

    The only issue that I noted is that the project from start contains in package.json the plugin mentions and npm i will then generate target/plugins/... folders which are empty and on the first mvn execution these were for some reason not populated even though they should always be copied.

    Then again what is the use of running npm i manually for flow when the use case of flow is to abstract and handle this automatically? Also Flow will in any case execute npm i as the hash will be missing.

  4. Artur- commented on Mar 8, 2022

    @Artur-
    Member

    "npm i" can be run automatically by the IDE in some cases. Either after asking the user or automatically

  5. caalador commented on Mar 8, 2022

    @caalador
    Contributor

    I just noted that the plugin files are copied to target, but something deletes them from the directories making the initial mvn execution fail. I expect that this has at least to a part something to do with the problem of symlinks in windows and not following and deleting the actual files that are linked. see #11177

  6. Artur- commented on Mar 8, 2022

    @Artur-
    Member

    Could we just publish the plugins to npm for real?

  7. caalador commented on Mar 8, 2022

    @caalador
    Contributor

    I would rather they were used as scripts and not have them handled through npm at all.

  8. self-assigned this
    on Mar 8, 2022
  9. added 2 commits that reference this issue on Mar 8, 2022
    4a0034d
    2557d83
  10. added a commit that references this issue on Mar 15, 2022
    842177c
  11. added a commit that references this issue on Mar 15, 2022
    7cd275f
  12. added a commit that references this issue on Mar 15, 2022
    dee1435
  13. vaadin-bot commented on Mar 28, 2022

    @vaadin-bot
    Collaborator

    This ticket/PR has been released with Vaadin 23.0.3.

  14. tarekoraby commented on Mar 29, 2022

    @tarekoraby
    ContributorAuthor

    The issue is still present in 23.0.3. I just replicated it by running npm install on the skeleton-starter-flow-spring project, followed by mvn.

  15. added a commit that references this issue on Mar 29, 2022
    a9ce6f5
  16. added a commit that references this issue on Mar 30, 2022
    ff0775b
  17. added a commit that references this issue on Mar 30, 2022
    b148b6d
  18. added a commit that references this issue on Mar 30, 2022
    bc67ae4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions