You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Vite doesn't work with a custom theme that packaged as jar #13538
application-theme-plugin/theme-loader cannot find the packaged theme because the themeResourceFolder value on vaadin-dev-server-settings.json is not correct .
The application starts in dev mode but vite dev server cannot find the resources. It's looking for them in frontend/themes but they are in target/flow-frontend/themes
custom-theme-demo with vaadin.version=23.0.3 and webpack works properly.
Versions:
- Vaadin / Flow version: 23.0.3
- Java version: 17.0.1
- Development or production mode: development
The demo uses a packaged theme (custom-theme) and extends it. The fix solves the first part (i.e. reusing-theme-jar-demo works fine) but you cannot inherit from custom.
On the flow test side it would be flow-tests/test-application-theme/test-reusable-as-parent/ that fails with vite due to the alias resolution not being run each time the alias is encountered, but only once it seems.
So now it sets the alias to the reusable folder, as it is gotten first, and can't then find the actual theme files anymore as they arre not under target.
Activity
fix: reusable themes with vite
fix: reusable themes with vite
fix: reusable themes with vite
fix: reusable themes with vite (#13543)
fix: reusable themes with vite (#13543)
fix: reusable themes with vite (#13543) (CP: 23.0) (#13568)
vaadin-bot commentedon May 2, 2022
This ticket/PR has been released with Vaadin 23.0.8.
3 remaining items
Artur- commentedon May 12, 2022
Is the original test case still valid for testing this?
jorginius commentedon May 12, 2022
I think so.
The "Minimal reproducible example" is the
extend-existing-app-theme-demo
The demo uses a packaged theme (
custom-theme) and extends it. The fix solves the first part (i.e. reusing-theme-jar-demo works fine) but you cannot inherit from custom.caalador commentedon May 13, 2022
On the flow test side it would be
flow-tests/test-application-theme/test-reusable-as-parent/that fails with vite due to the alias resolution not being run each time the alias is encountered, but only once it seems.So now it sets the alias to the reusable folder, as it is gotten first, and can't then find the actual theme files anymore as they arre not under target.
mshabarov commentedon May 24, 2022
To be cherry-picked to Vaadin 22 manually.
fix: reusable themes with vite (#13543)
fix: Reusable themes with vite (#13543)
fix: Fix theme paths resolution when using Vite (CP: 9.0) (#13865)
vaadin-bot commentedon Jun 3, 2022
This ticket/PR has been released with Vaadin 23.1.0.rc2 and is also targeting the upcoming stable 23.1.0 version.
vaadin-bot commentedon Jun 7, 2022
This ticket/PR has been released with Vaadin 22.0.16.