Skip to content

HasDynamicTitle.getPageTitle() should run after AfterNavigationEvent #13812

Closed

Description

@tarekoraby

Describe your motivation

Setting the page title dynamically by implementing HasDynamicTitle doesn't work as desired in cases where the title is only available after AfterNavigationEvent is completed. For those cases, one would need to call UI.getCurrent().getPage().setTitle() upon the AfterNavigationEvent.

Describe the solution you'd like

HasDynamicTitle.getPageTitle() should run after AfterNavigationEvent is completed (or run twice before and after).

Activity

  1. tarekoraby commented on May 20, 2022

    @tarekoraby
    ContributorAuthor

    Just discussed this with @mshabarov, and we agreed that this should be classified as a bug since our documentation states that:

    AfterNavigationEvent is the third and last event fired during navigation. This event is typically used to update various parts of the UI after the actual navigation is complete.

    Hence, the fact that HasDynamicTitle.getPageTitle() (which updates the UI) is running before the AfterNavigationEvent is started should be considered as an erroneous behavior.

  2. added a commit that references this issue on May 23, 2022
    697f484
  3. added 3 commits that reference this issue on May 23, 2022
    75ae40a
    dcac8bd
    06c4ead
  4. added 3 commits that reference this issue on May 23, 2022
    615effa
    e10a7b7
    65641b1
  5. vaadin-bot commented on May 26, 2022

    @vaadin-bot
    Collaborator

    This ticket/PR has been released with Vaadin 23.1.0.rc1 and is also targeting the upcoming stable 23.1.0 version.

  6. vaadin-bot commented on Jun 6, 2022

    @vaadin-bot
    Collaborator

    This ticket/PR has been released with Vaadin 23.0.11.

  7. vaadin-bot commented on Jun 7, 2022

    @vaadin-bot
    Collaborator

    This ticket/PR has been released with Vaadin 22.0.16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions