You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
HasDynamicTitle.getPageTitle() should run after AfterNavigationEvent #13812
Setting the page title dynamically by implementing HasDynamicTitle doesn't work as desired in cases where the title is only available after AfterNavigationEvent is completed. For those cases, one would need to call UI.getCurrent().getPage().setTitle() upon the AfterNavigationEvent.
Describe the solution you'd like
HasDynamicTitle.getPageTitle() should run after AfterNavigationEvent is completed (or run twice before and after).
Just discussed this with @mshabarov, and we agreed that this should be classified as a bug since our documentation states that:
AfterNavigationEvent is the third and last event fired during navigation. This event is typically used to update various parts of the UI after the actual navigation is complete.
Hence, the fact that HasDynamicTitle.getPageTitle() (which updates the UI) is running before the AfterNavigationEvent is started should be considered as an erroneous behavior.
Activity
tarekoraby commentedon May 20, 2022
Just discussed this with @mshabarov, and we agreed that this should be classified as a bug since our documentation states that:
Hence, the fact that
HasDynamicTitle.getPageTitle()(which updates the UI) is running before theAfterNavigationEventis started should be considered as an erroneous behavior.fix: Update Page Title after processing AfterNavigation listeners (#1…
fix: Update Page Title after processing AfterNavigation listeners (#1…
fix: Update Page Title after processing AfterNavigation listeners (#1…
fix: Update Page Title after processing AfterNavigation listeners (#1…
fix: Update Page Title after processing AfterNavigation listeners (#1…
fix: Update Page Title after processing AfterNavigation listeners (#1…
fix: Update Page Title after processing AfterNavigation listeners (#1…
vaadin-bot commentedon May 26, 2022
This ticket/PR has been released with Vaadin 23.1.0.rc1 and is also targeting the upcoming stable 23.1.0 version.
vaadin-bot commentedon Jun 6, 2022
This ticket/PR has been released with Vaadin 23.0.11.
vaadin-bot commentedon Jun 7, 2022
This ticket/PR has been released with Vaadin 22.0.16.
fix: revert title changes from fix for vaadin#13812 (vaadin#13871)