Skip to content

Theme generators always works in production mode #14228

Closed

Description

@mcollovati

Description of the bug

With Vite the theme-generator plugin always works in production mode, since the devMode = false is hard-coded in themeOptions.
This makes dev server fail to start when the styles.css is not present at startup.
In dev mode an empty file is created by the theme-generator plugin, but with Vite the flag is always true so the file is not generated and then the compilation fails.

Minimal reproducible example

Issue can be replicated running ThemeLiveReloadIT (flow-tests/test-application-theme/test-theme-live-reload) with Vite enabled

Expected behavior

styles.css is created and Vite compilation completes succesfully

Actual behavior

styles.css is not created and Vite compilation fails

Versions:

- Vaadin / Flow version: 23.2
- Java version: 11
- Development mode
- Test from Flow codebase

Activity

  1. added a commit that references this issue on Jul 28, 2022
    aa4c495
  2. added a commit that references this issue on Jul 28, 2022
    5e18e24
  3. added a commit that references this issue on Jul 28, 2022
    03bdfba
  4. added a commit that references this issue on Jul 28, 2022
    be28afc
  5. vaadin-bot commented on Aug 9, 2022

    @vaadin-bot
    Collaborator

    This ticket/PR has been released with Vaadin 23.1.6.

  6. vaadin-bot commented on Aug 18, 2022

    @vaadin-bot
    Collaborator

    This ticket/PR has been released with Vaadin 23.2.0.beta1 and is also targeting the upcoming stable 23.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions