You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Theme generators always works in production mode #14228
With Vite the theme-generator plugin always works in production mode, since the devMode = false is hard-coded in themeOptions.
This makes dev server fail to start when the styles.css is not present at startup.
In dev mode an empty file is created by the theme-generator plugin, but with Vite the flag is always true so the file is not generated and then the compilation fails.
Minimal reproducible example
Issue can be replicated running ThemeLiveReloadIT (flow-tests/test-application-theme/test-theme-live-reload) with Vite enabled
Expected behavior
styles.css is created and Vite compilation completes succesfully
Actual behavior
styles.css is not created and Vite compilation fails
Versions:
- Vaadin / Flow version: 23.2
- Java version: 11
- Development mode
- Test from Flow codebase
Activity
fix: provide correct devMode flag to theme-generator with Vite
fix: provide correct devMode flag to theme-generator with Vite (#14230)
fix: provide correct devMode flag to theme-generator with Vite (#14230)
fix: provide correct devMode flag to theme-generator with Vite (#14230)…
vaadin-bot commentedon Aug 9, 2022
This ticket/PR has been released with Vaadin 23.1.6.
vaadin-bot commentedon Aug 18, 2022
This ticket/PR has been released with Vaadin 23.2.0.beta1 and is also targeting the upcoming stable 23.2.0 version.