Skip to content

System property for Feature Flag does not override value when loading features file with ResourceProvider #14679

Closed

Description

@mcollovati

In #14408 we introduced the possibility to override feature flags value by setting a system property.
This works fine unless a ResourceProvider is used to load the feature flags file; in this case the system property is ignored.

Activity

  1. mcollovati commented on Sep 28, 2022

    @mcollovati
    CollaboratorAuthor

    @cromoteca could you please confirm that the original idea was that a system property should always have precedence over the value stored in the feature flags file?

  2. cromoteca commented on Sep 28, 2022

    @cromoteca
    Contributor

    It was not our use case, I think that it's up to you to set the priorities. I'd give priority to the system property anyway.

  3. added a commit that references this issue on Sep 29, 2022
    36f15d6
  4. added a commit that references this issue on Sep 29, 2022
    0002980
  5. added 2 commits that reference this issue on Sep 29, 2022
    bb5e5f5
    6a5414a
  6. vaadin-bot commented on Oct 3, 2022

    @vaadin-bot
    Collaborator

    This ticket/PR has been released with Vaadin 23.2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions