You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Do not build Brotli files for the dev mode bundle #16028
When you have an application specific bundle, it looks weird that you have both an indexhtml.js.foo and an indexhtml.js.foo.br. Especially when you are supposed to commit the bundle to the repository, the binary files become weird.
The default dev bundle package is larger than it needs to be also as it includes both uncompressed and compressed versions of all files.
Describe the solution you'd like
Do not build any compressed files when building a dev bundle.
I'd propose to also combine the generated files into one, so that it wouldn't look so massive change now whenever one updates a vaadin version or fixes a typo in a javascript file.
This (and my above suggestion) would also be a major DX improvement. In my test project I removed one letter in a JS file (frontend/script.js) and now my git status looks like this:
mstahv@MatinPikkuRakkine calling-java-from-javascript % git status
On branch master
Your branch is up to date with 'origin/master'.
Changes not staged for commit:
(use "git add/rm <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: frontend/script.js
modified: src/main/dev-bundle/config/stats.json
deleted: src/main/dev-bundle/webapp/VAADIN/build/component-picker-b2a146a3.js
deleted: src/main/dev-bundle/webapp/VAADIN/build/component-picker-b2a146a3.js.br
deleted: src/main/dev-bundle/webapp/VAADIN/build/generated-flow-imports-307aadcc.js
deleted: src/main/dev-bundle/webapp/VAADIN/build/generated-flow-imports-307aadcc.js.br
deleted: src/main/dev-bundle/webapp/VAADIN/build/indexhtml-27dcf4fe.js
deleted: src/main/dev-bundle/webapp/VAADIN/build/indexhtml-27dcf4fe.js.br
modified: src/main/dev-bundle/webapp/index.html
modified: src/main/dev-bundle/webapp/index.html.br
Untracked files:
(use "git add <file>..." to include in what will be committed)
frontend/index.html
package-lock.json
package.json
src/main/dev-bundle/webapp/VAADIN/build/component-picker-ac625ebd.js
src/main/dev-bundle/webapp/VAADIN/build/component-picker-ac625ebd.js.br
src/main/dev-bundle/webapp/VAADIN/build/generated-flow-imports-831d1f55.js
src/main/dev-bundle/webapp/VAADIN/build/generated-flow-imports-831d1f55.js.br
src/main/dev-bundle/webapp/VAADIN/build/indexhtml-c8b67409.js
src/main/dev-bundle/webapp/VAADIN/build/indexhtml-c8b67409.js.br
tsconfig.json
types.d.ts
vite.config.ts
vite.generated.ts
no changes added to commit (use "git add" and/or "git commit -a")
Activity
mstahv commentedon Mar 8, 2023
I'd propose to also combine the generated files into one, so that it wouldn't look so massive change now whenever one updates a vaadin version or fixes a typo in a javascript file.
mstahv commentedon Mar 8, 2023
This (and my above suggestion) would also be a major DX improvement. In my test project I removed one letter in a JS file (frontend/script.js) and now my git status looks like this:
fix: Do not build Brotli files for the dev bundle
fix: Do not build Brotli files for the dev bundle (#16344)
fix: Do not build Brotli files for the dev bundle (#16344)
fix: Do not build Brotli files for the dev bundle (#16344) (#16350)
vaadin-bot commentedon Mar 23, 2023
This ticket/PR has been released with Vaadin 24.1.0.alpha1 and is also targeting the upcoming stable 24.1.0 version.
vaadin-bot commentedon Mar 24, 2023
This ticket/PR has been released with Vaadin 24.0.2.