Skip to content

Sample code in the generated routes.tsx does not compile #19178

Closed

Description

@Legioth

Description of the bug

The sample code for withReactRoutes in the comment in frontend/generated/routes.tsx does not compile when commented out. The function expects an array of route objets but the example code passes two separate objects rather than an array. Adding [ to the beginning and ] to the end works.

Expected behavior

Expected that example code is syntactically correct.

Minimal reproducible example

  1. npx @hilla/cli init --react --pre my-hilla
  2. Change to version 24.4.0.alpha22
  3. mvn

Versions

Vaadin 24.4.0.alpha22

Activity

  1. self-assigned this
    on Apr 17, 2024
  2. moved this from 🟢Ready to Go to ⚒️ In progress in Vaadin Flow | Hilla | Kits ongoing workon Apr 17, 2024
  3. added a commit that references this issue on Apr 17, 2024
    f767088
  4. added a commit that references this issue on Apr 18, 2024
    03106e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions