Skip to content

Lumo class should be deprecated and just load stylesheets in V25 #21605

Description

@rolfsmeds

Describe your motivation

Currently, applying a theme (in practice Lumo or Material) rewrites components' JSModule paths to the theme-specific module.

As of V25, Material is removed, and the Lumo styles for components are no longer loaded as part of the component dependencies but as regular stylesheets loaded separately from the components themselves: @CssImport("@vaadin/vaadin-lumo-styles/lumo.css") or, in css, @import("@vaadin/vaadin-lumo-styles/lumo.css").

The @Theme annotation is deprecated but retained for backward compatibility, but only as a shorthand for loading the Lumo stylesheet, and, if specified, the application theme. The Lumo class itself should be similarly deprecated but retained, as it only serves a legacy purpose.

Describe the solution you'd like

  • @Theme(themeClass=Lumo.class) should just do a @CssImport("@vaadin/vaadin-lumo-styles/lumo.css")
  • @Theme("mytheme") should do the import and then load the specified folder's styles.css
  • @Theme(themeClass=Lumo.class, variant=Lumo.DARK) should do the import and apply the theme="dark" to the page (as it does today).

Perhaps this could be implemented simply by a @CssImport in the Lumo theme class, instead of the current lumo-styles npm package import?

Additionally, the Lumo theme class should no longer load various JSModules as these will no longer exist.

Finally, the Lumo class should be deprecated in V25.

Activity

  1. changed the title [-]@Theme should just load stylesheets in V25[/-] [+]Lumo should just load stylesheets in V25[/+] on Jun 4, 2025
  2. moved this from 🪵Product backlog to 🟢Ready to Go in Vaadin Flow | Hilla | Kits ongoing workon Jun 23, 2025
  3. self-assigned this
    on Jun 23, 2025
  4. moved this from 🟢Ready to Go to ⚒️ In progress in Vaadin Flow | Hilla | Kits ongoing workon Jun 23, 2025
  5. moved this from ⚒️ In progress to 🔎Iteration reviews in Vaadin Flow | Hilla | Kits ongoing workon Jun 26, 2025
  6. changed the title [-]Lumo should just load stylesheets in V25[/-] [+]Lumo class should be deprecated and just load stylesheets in V25[/+] on Jul 22, 2025
  7. added a commit that references this issue on Aug 8, 2025
  8. added a commit that references this issue on Aug 8, 2025
  9. moved this from 🔎Iteration reviews to ⚒️ In progress in Vaadin Flow | Hilla | Kits ongoing workon Aug 13, 2025
  10. moved this from ⚒️ In progress to 🟢Ready to Go in Vaadin Flow | Hilla | Kits ongoing workon Aug 13, 2025
  11. moved this from 🟢Ready to Go to ⚒️ In progress in Vaadin Flow | Hilla | Kits ongoing workon Aug 13, 2025
  12. added a commit that references this issue on Aug 18, 2025
    98c9b50
  13. moved this from ⚒️ In progress to 🔎Iteration reviews in Vaadin Flow | Hilla | Kits ongoing workon Aug 20, 2025
  14. added a commit that references this issue on Aug 20, 2025
    8651d8d
  15. vaadin-bot commented on Aug 22, 2025

    @vaadin-bot
    Collaborator

    This ticket/PR has been released with Vaadin 25.0.0-alpha7.

  16. added a commit that references this issue on Oct 1, 2025
    15a696c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions