You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Adding flow-dev-deps module to platform cause error running tests #9345
Adding the mentioned module into platform causes platform validation failed with following errors:
[INFO] --- vaadin-maven-plugin:18.0-SNAPSHOT:build-frontend (default) @ vaadin-platform-test ---
<something more in the thread>
TypeError: Cannot read property 'then' of undefined
at C:\WorkFolder\platform\vaadin-platform-test\node_modules\.pnpm\registry.npmjs.org\cacache\15.0.5\node_modules\cacache\lib\util\fix-owner.js:113:7
at enqueue (C:\WorkFolder\platform\vaadin-platform-test\node_modules\.pnpm\registry.npmjs.org\compression-webpack-plugin\4.0.1_webpack@4.42.0\node_modules\compression-webpack-plugin\dist\index.js:208:11)
at async Promise.all (index 0)
at C:\WorkFolder\platform\vaadin-platform-test\node_modules\.pnpm\registry.npmjs.org\compression-webpack-plugin\4.0.1_webpack@4.42.0\node_modules\compression-webpack-plugin\dist\index.js:270:7
It seems that the flow-dev-deps module is not used by any of our IT modules so there is nothing that makes sure that the dependencies even work.
It is another question what does cause cacache failure there, mayhaps the compression-webpack-plugin is not working with that particular cacache version or something else not working with cacache.
It seems that the flow-dev-deps module is not used by any of our IT modules so there is nothing that makes sure that the dependencies even work.
It is another question what does cause cacache failure there, mayhaps the compression-webpack-plugin is not working with that particular cacache version or something else not working with cacache.
yes and no.
yes: there are no test which confirms that deps are working
no: deps are calculated based on built test. Once one of our IT is built the command is executed which outputs all used dev dependencies. Those dependencies are collected then into the resource file which is packaged into flow-dev-deps.
I may assume that the problem is unsolvable in fact: the dependencies which are used are not in flat list.
There is a dependency tree. Different dependencies may use different transitive dependency versions.
That has been seen during impl. I hoped that the chosen way of detecting dependency version is good enough but probably it's not.
As a result locking dep versions via pnpmfile.js becomes quite nontrivial task: it's not designed to work with dependency tree.
Activity
pleku commentedon Nov 11, 2020
It seems that the
flow-dev-depsmodule is not used by any of our IT modules so there is nothing that makes sure that the dependencies even work.It is another question what does cause
cacachefailure there, mayhaps thecompression-webpack-pluginis not working with that particularcacacheversion or something else not working withcacache.denis-anisimov commentedon Nov 11, 2020
yes and no.
yes: there are no test which confirms that deps are working
no: deps are calculated based on built test. Once one of our IT is built the command is executed which outputs all used dev dependencies. Those dependencies are collected then into the resource file which is packaged into
flow-dev-deps.I may assume that the problem is unsolvable in fact: the dependencies which are used are not in flat list.
There is a dependency tree. Different dependencies may use different transitive dependency versions.
That has been seen during impl. I hoped that the chosen way of detecting dependency version is good enough but probably it's not.
As a result locking dep versions via
pnpmfile.jsbecomes quite nontrivial task: it's not designed to work with dependency tree.Stop logging error when updating dev dependencies
Stop logging error when updating dev dependencies (#9476)
Stop logging error when updating dev dependencies (#9476)
Stop logging error when updating dev dependencies (#9476)
Stop logging error when updating dev dependencies (#9476)
17 remaining items
fix: remove functionality which tries to pin dev dependencies (#11456) (
fix: remove functionality which tries to pin dev dependencies (#11456) (
vaadin-bot commentedon Aug 6, 2021
This ticket/PR has been released with platform 22.0.0.alpha1 and is also targeting the upcoming stable 22.0.0 version.
vaadin-bot commentedon Aug 6, 2021
This ticket/PR has been released with platform 21.0.0.beta1 and is also targeting the upcoming stable 21.0.0 version.
vaadin-bot commentedon Aug 9, 2021
This ticket/PR has been released with platform 14.7.0.alpha3 and is also targeting the upcoming stable 14.7.0 version.
vaadin-bot commentedon Aug 9, 2021
This ticket/PR has been released with platform 20.0.6.
vaadin-bot commentedon Sep 13, 2021
This ticket/PR has been released with platform 14.6.9.