Repository navigation
refactor!: remove theme modules from Flow - #10220
Conversation
Remove the Lumo and Material theme modules from Flow project to have them in the components project instead. Closes #10182
af60ef0 to
7906cdb
Compare
|
Looks like reusable theme tests need to be updated as well: |
1de6456 to
54014ad
Compare
Create a Lumo class for test use inside test-common.
54014ad to
b31847a
Compare
pleku
left a comment
There was a problem hiding this comment.
Couple of questions, probably to @web-padawan :
- are all the theme ITs (from here) moved to the components project too ?
- is the plan to take the changes to 14.x version of the components too ? I was just wondering how that will work from versioning perspective ...
|
The test failure in the build doesn't seem related to this issue nor really anything else either |
|
@pleku Thank you for taking a look.
|
To clarify, @web-padawan you're referring to the web components ? As the flow integrations are in https://github.com/vaadin/vaadin-flow-components/tree/14.5 already but there would be a need to make changes to the web components too and that is not done ? Anyway, I think it is fine. Then there is no problem with the versioning. And the pace of updates for v14 versions will probably wind down during the H2 of this year so there should not probably be any trouble for backporting things (nothing or very little to backport). |
|
Yes, I was talking about web components monorepo (we will not use that for Vaadin 14). The main reason for moving theme integrations to |
171187a to
a452417
Compare
235a31e to
466c82d
Compare
Create a test module with Lumo class used for testing in modules requiring the default theme (Lumo).
466c82d to
77b0304
Compare
|
This ticket/PR has been released with platform 20.0.0. For prerelease versions, it will be included in its final version. |
Remove the Lumo and Material theme
modules from Flow project to have them
in the components project instead.
Closes #10182