Skip to content

refactor!: remove theme modules from Flow - #10220

Merged
pleku merged 3 commits into
masterfrom
issues/10182_remove_themes
Mar 11, 2021
Merged

pleku merged 3 commits into
masterfrom
issues/10182_remove_themes

Conversation

@caalador

@caalador caalador commented Mar 8, 2021

Copy link
Copy Markdown
Contributor

Remove the Lumo and Material theme
modules from Flow project to have them
in the components project instead.

Closes #10182

Remove the Lumo and Material theme
modules from Flow project to have them
in the components project instead.

Closes #10182
@caalador
caalador force-pushed the issues/10182_remove_themes branch from af60ef0 to 7906cdb Compare March 8, 2021 10:26
@web-padawan

Copy link
Copy Markdown
Member

Looks like reusable theme tests need to be updated as well:

[Step 5/11] Failed to execute goal on project flow-test-application-theme-reusable: Could not resolve dependencies for project com.vaadin:flow-test-application-theme-reusable:war:1111.5.0-SNAPSHOT: Could not find artifact com.vaadin:vaadin-lumo-theme:jar:1111.5.0-SNAPSHOT in vaadin-prereleases (https://maven.vaadin.com/vaadin-prereleases/)

Create a Lumo class for test use inside
test-common.
@caalador
caalador force-pushed the issues/10182_remove_themes branch from 54014ad to b31847a Compare March 8, 2021 16:16

@pleku pleku left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions, probably to @web-padawan :

  1. are all the theme ITs (from here) moved to the components project too ?
  2. is the plan to take the changes to 14.x version of the components too ? I was just wondering how that will work from versioning perspective ...

@pleku

pleku commented Mar 9, 2021

Copy link
Copy Markdown

The test failure in the build doesn't seem related to this issue nor really anything else either

@web-padawan

Copy link
Copy Markdown
Member

@pleku Thank you for taking a look.

  1. All the theme ITs will be moved to the Flow components monorepo. There is now a PR for moving sources: feat: move lumo and material themes from flow to mono-repo flow-components#706, @manolo mentioned that ITs will be moved separately.
  2. We are not planning to make this change for 14.x version of components. Vaadin 14 will not use the new monorepo.

@pleku

pleku commented Mar 9, 2021 •

Copy link
Copy Markdown
  1. We are not planning to make this change for 14.x version of components. Vaadin 14 will not use the new monorepo.

To clarify, @web-padawan you're referring to the web components ? As the flow integrations are in https://github.com/vaadin/vaadin-flow-components/tree/14.5 already but there would be a need to make changes to the web components too and that is not done ?

Anyway, I think it is fine. Then there is no problem with the versioning. And the pace of updates for v14 versions will probably wind down during the H2 of this year so there should not probably be any trouble for backporting things (nothing or very little to backport).

@web-padawan

Copy link
Copy Markdown
Member

Yes, I was talking about web components monorepo (we will not use that for Vaadin 14).

The main reason for moving theme integrations to vaadin-flow-components is to make it easier for us to release things.
In theory nothing should prevent us from moving Flow theme integrations also for 14.x but I don't see a need for this.

@caalador
caalador force-pushed the issues/10182_remove_themes branch from 171187a to a452417 Compare March 9, 2021 11:46
@caalador
caalador force-pushed the issues/10182_remove_themes branch 5 times, most recently from 235a31e to 466c82d Compare March 11, 2021 08:35
Create a test module with Lumo
class used for testing in modules
requiring the default theme (Lumo).
@caalador
caalador force-pushed the issues/10182_remove_themes branch from 466c82d to 77b0304 Compare March 11, 2021 10:23
@caalador
caalador requested a review from pleku March 11, 2021 11:27

@pleku pleku left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on existing discussion #10220 (comment)

@pleku pleku changed the title chore: remove theme modules from Flow refactor!: remove theme modules from Flow Mar 11, 2021
@pleku
pleku merged commit e0a1483 into master Mar 11, 2021
@pleku
pleku deleted the issues/10182_remove_themes branch March 11, 2021 13:47
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 20.0.0. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Vaadin 20] Move Lumo and Material theme integrations to Flow components

5 participants