Repository navigation
Make JavaScriptBootHandler only respond to servlet path and not all sub paths - #10431
Conversation
a001c68 to
47b0e71
Compare
This is what is mostly needed for all implementations and getting it through the request is more a workaround. The request is typically not needed at all and relying on the internals of the request is problematic if we change how the request is done, as is being done in e.g. #10431
This is what is mostly needed for all implementations and getting it through the request is more a workaround. The request is typically not needed at all and relying on the internals of the request is problematic if we change how the request is done, as is being done in e.g. #10431
This is what is mostly needed for all implementations and getting it through the request is more a workaround. The request is typically not needed at all and relying on the internals of the request is problematic if we change how the request is done, as is being done in e.g. #10431
This is what is mostly needed for all implementations and getting it through the request is more a workaround. The request is typically not needed at all and relying on the internals of the request is problematic if we change how the request is done, as is being done in e.g. #10431
8125a7f to
6d7adbc
Compare
This is what is mostly needed for all implementations and getting it through the request is more a workaround. The request is typically not needed at all and relying on the internals of the request is problematic if we change how the request is done, as is being done in e.g. #10431
This is what is mostly needed for all implementations and getting it through the request is more a workaround. The request is typically not needed at all and relying on the internals of the request is problematic if we change how the request is done, as is being done in e.g. #10431
e81e997 to
0c3370e
Compare
This is what is mostly needed for all implementations and getting it through the request is more a workaround. The request is typically not needed at all and relying on the internals of the request is problematic if we change how the request is done, as is being done in e.g. #10431
…ubpaths Needed for #10363 and vaadin/spring#735
194359c to
197c526
Compare
Also allow locations containing "?"
…nto scope-js-bootstraphandler
…nto scope-js-bootstraphandler
| * @deprecated use {@link #initializeUI(UI, Location)} instead | ||
| */ | ||
| @Deprecated | ||
| public void initializeUI(UI ui, VaadinRequest initRequest) { |
| * @deprecated use {@link #resolvePageConfigurationHolder(UI, Location)} instead | ||
| */ | ||
| @Deprecated | ||
| public static Optional<Class<?>> resolvePageConfigurationHolder(UI ui, |
|
SonarQube analysis reported 3 issues Watch the comments in this conversation to review them. 1 extra issueNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
) This is a prerequisite to allow JavaScriptBootstrapHandler to pass the route path as a query parameter instead of relying on the request path info. Related to #10431
pleku
left a comment
There was a problem hiding this comment.
Would it be a terrible idea to add an IT that verifies that someone does later on add code that breaks the assumption that sub paths don't work with JSBH ? So basically checking that a request to /foo?v-r=init... would not work ?
|
Added a unit test |
pleku
left a comment
There was a problem hiding this comment.
I was requesting for an IT but this is better than nothing.
|
What would an IT test? It is not an end user feature |
Verify that nothing is served from bootstrap if you craft an init request with subpath. But now thinking about it, not sure what adding it would even gain. |



Needed for #10363 and vaadin/spring#735