Skip to content

feat: add EndpointUtil.isAnonymousEndpoint - #10611

Merged
joheriks merged 3 commits into
masterfrom
is-anon-endpoint
Apr 15, 2021
Merged

joheriks merged 3 commits into
masterfrom
is-anon-endpoint

Conversation

@Artur-

@Artur- Artur- commented Apr 9, 2021

Copy link
Copy Markdown
Member

Fixes #10608

Based on #10610

@Artur-
Artur- force-pushed the is-anon-endpoint branch 3 times, most recently from 36e5332 to 0497fa0 Compare April 11, 2021 17:36
@haijian-vaadin haijian-vaadin changed the title Add EndpointUtil.isAnonymousEndpoint feat: add EndpointUtil.isAnonymousEndpoint Apr 13, 2021
@haijian-vaadin haijian-vaadin added the hilla Issues related to Hilla label Apr 13, 2021
@haijian-vaadin

Copy link
Copy Markdown
Contributor

#10610 has been merged, this one could be rebased?

@Artur-
Artur- force-pushed the is-anon-endpoint branch from 0497fa0 to 6a6b988 Compare April 14, 2021 08:09
@Artur-

Artur- commented Apr 14, 2021

Copy link
Copy Markdown
Member Author

Done. Is it a problem to change the spring-web dependency version?

@haijian-vaadin

Copy link
Copy Markdown
Contributor

Done. Is it a problem to change the spring-web dependency version?

updating the version should be fine. But why not change the spring.version property to 5.3.0? so that other spring dependencies would be updated as well?

@Artur-

Artur- commented Apr 14, 2021

Copy link
Copy Markdown
Member Author

I can do that but won't this mean dropping support for Spring Boot < 2.4? https://spring.io/blog/2020/11/12/spring-boot-2-4-0-available-now mentions that Spring Boot 2.4 upgrades to Spring 5.3

@Artur-

Artur- commented Apr 14, 2021

Copy link
Copy Markdown
Member Author

Fixed. Upgrading the Spring dependency should not be a problem as we are not backporting this change anyway

Comment thread fusion-endpoint/pom.xml Resolved
@joheriks
joheriks merged commit 8c3d055 into master Apr 15, 2021
@joheriks
joheriks deleted the is-anon-endpoint branch April 15, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hilla Issues related to Hilla +0.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a method to EndpointUtil to check if a given URL will end up in an @AnonymousAllowed endpoint

4 participants