Repository navigation
feat: Add view access checker - #10800
Conversation
05cbc1b to
96bd822
Compare
There was a problem hiding this comment.
Some questions:
-
How the ViewAccessChecker would be enabled? (I mean not using spring add-on) Should the user add it as
beforeEnterListenerthroughVaadinServiceInitListeneror ...? -
Shouldn't some unit tests or ITs be added for these changes, especially the ViewAccessChecker class?
And the ViewAccessChecker does not comply with line wrapping length of 80 defined for flow repo.
Yes, as it is used by the Spring integration in https://github.com/vaadin/spring/blob/456d653ca5743b81cdea4ce672170942296dee9a/vaadin-spring/src/main/java/com/vaadin/flow/spring/security/ViewAccessCheckerInitializer.java |
|
Added unit tests, fixed formatting |
9bf332c to
088d28c
Compare
reorder imports based on flow repo rules
rename anon to anonymous
caalador
left a comment
There was a problem hiding this comment.
Would it make sense to have an IT module with full usage including the pluging into a UI instance?
Else seems fine after the 2 minor additions/changes
It would. Right now it is in vaadin/spring#780 |
|
Added "access denied" in dev mode. |
taefi
left a comment
There was a problem hiding this comment.
Other than the comment on nullability of configuration, looks good to me.
|
Can configuration ever be null really? |
|
Only if the UI is not connected to a VaadinSession. I don't think its probable that this would ever be the case here. |
|
Yeah, not in a real "before enter" event |
|
This ticket/PR has been released with platform 21.0.0.alpha3. For prerelease versions, it will be included in its final version. |
Fixes #10609