Skip to content

Permit access to /themes/** - #11040

Merged
pleku merged 1 commit into
masterfrom
allow-theme-static-resources
May 21, 2021
Merged

pleku merged 1 commit into
masterfrom
allow-theme-static-resources

Conversation

@Artur-

@Artur- Artur- commented May 20, 2021

Copy link
Copy Markdown
Member

Description

Fixes vaadin/spring#802

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 2 issues

  1. MAJOR HandlerHelper.java#L322: Define and throw a dedicated exception instead of using a generic one. rule
  2. INFO HandlerHelper.java#L334: Public static com.vaadin.flow.server.HandlerHelper.getPublicResources() may expose internal representation by returning HandlerHelper.publicResources rule

@pleku
pleku merged commit 3c2a16d into master May 21, 2021
@pleku
pleku deleted the allow-theme-static-resources branch May 21, 2021 08:45
vaadin-bot pushed a commit that referenced this pull request May 21, 2021
vaadin-bot added a commit that referenced this pull request May 21, 2021
Fixes vaadin/spring#802

Co-authored-by: Artur <artur@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 21.0.0.alpha3. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VaadinWebSecurityConfigurerAdapter.configure() doesn't automatically configure permitAll for /themes/

3 participants