Repository navigation
Conversation
|
Seems like this approach has a problem at least with Jetty. Jetty (in the included test) serializes the session after each request so after the first serialization, when |
Avoids writing VaadinSession to the HTTP session when the controlling properties are set (devmode + parameter). For implementation reasons, something must be serialized so only a boolean is written and these kind of "not actually serialized" sessions are removed when loading them after deserialization. Fixes #11151
|
Took another approach which skips serialization instead of removing it from the session |
Avoids writing VaadinSession to the HTTP session when the controlling properties are set (devmode + parameter). For implementation reasons, something must be serialized so only a boolean is written and these kind of "not actually serialized" sessions are removed when loading them after deserialization. Fixes #11151
pleku
left a comment
There was a problem hiding this comment.
I'm going to test with some other projects+servers too
pleku
left a comment
There was a problem hiding this comment.
Tested with TomEE and it worked there too. Tried with Jboss/Wildfly but run into other issues and could not get to test hot deploy capabilities easily ...
@denis-anisimov are you going to take a look or not ?
|
Also, maybe there should be a mention of this behavior in https://github.com/vaadin/docs/blob/latest/articles/guide/live-reload/index.asciidoc, can you make a PR there @Artur- ? Essentially I would just add a note that this behavior is there to make it easier to develop apps while keeping authentication features enabled, and that the behavior will not be the same for production apps. |
|
Immediate question: is it only targets the |
|
Only master |
yes. Is there any rush ? |
|
Docs in vaadin/docs#584 |
|
SonarQube analysis reported 7 issues
|
|
This ticket/PR has been released with platform 21.0.0.alpha8. For prerelease versions, it will be included in its final version. |





Fixes #11151