Skip to content

fix: use ServletContext classloader as a default classloader for service - #11308

Merged
pleku merged 2 commits into
masterfrom
4367-set-classloader-using-context
Jun 25, 2021
Merged

pleku merged 2 commits into
masterfrom
4367-set-classloader-using-context

Conversation

@denis-anisimov

@denis-anisimov denis-anisimov commented Jun 22, 2021 •

Copy link
Copy Markdown
Contributor

fixes #4367

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 4 issues

  1. MAJOR VaadinService.java#L392: Rename "instantiator" which hides the field declared at line 192. rule
  2. MINOR VaadinService.java#L333: Replace this lambda with a method reference. rule
  3. MINOR VaadinService.java#L395: Remove this use of "init"; it is deprecated. rule
  4. MINOR VaadinService.java#L409: Remove this use of "init"; it is deprecated. rule

@pleku
pleku merged commit 334d141 into master Jun 25, 2021
@pleku
pleku deleted the 4367-set-classloader-using-context branch June 25, 2021 08:55
@pleku pleku added the +0.0.1 label Jun 25, 2021
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @denis-anisimov and @pleku, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 334d141
error: could not apply 334d141... fix: use ServletContext classloader as a default classloader for service (#11308)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 21.0.0.alpha8. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VaadinService classloader is incorrectly set in the CTOR

3 participants