Skip to content

feat: add Vaadin Nonnull annotation - #11341

Merged
Lodin merged 11 commits into
masterfrom
feature/fusion/nonnull-annotation
Jun 28, 2021
Merged

Lodin merged 11 commits into
masterfrom
feature/fusion/nonnull-annotation

Conversation

@Lodin

@Lodin Lodin commented Jun 28, 2021 •

Copy link
Copy Markdown
Contributor

Adds a @Nonnull annotation that is applicable to not only fields/methods/parameters like javax.annotation.Nonnull but also to type parameters. It gives more control over the generated Typescript code.

It is still possible to use any other annotation with the case-insensitive nonnull name.

Resolves vaadin/hilla#50

@Lodin Lodin added the hilla Issues related to Hilla label Jun 28, 2021
@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 6 issues

  1. MAJOR VaadinConnectControllerConfiguration.java#L61: Make this anonymous inner class a lambda rule
  2. MAJOR VaadinConnectTsGenerator.java#: This file has 906 lines, which is greater than 750 authorized. Split it into smaller files. rule
  3. MINOR VaadinConnectController.java#L192: Remove this use of "APPLICATION_JSON_UTF8_VALUE"; it is deprecated. rule
  4. MINOR VaadinConnectControllerConfiguration.java#L103: Remove this use of "RequestMappingInfo"; it is deprecated. rule
  5. MINOR VaadinConnectTsGenerator.java#L337: Replace this if-then-else statement by a single return statement. rule
  6. INFO VaadinConnectControllerConfiguration.java#L101: Possible null pointer dereference in com.vaadin.fusion.VaadinConnectControllerConfiguration.prependEndpointPrefixUrl(RequestMappingInfo) due to return value of called method rule

@Lodin
Lodin enabled auto-merge (squash) June 28, 2021 12:58
@Lodin
Lodin merged commit 4e5fad4 into master Jun 28, 2021
@Lodin
Lodin deleted the feature/fusion/nonnull-annotation branch June 28, 2021 15:29
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 21.0.0.alpha9. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a Vaadin Nonnull annotation

3 participants