Skip to content

fix: use dedicated namespace for fallback style imports - #11419

Merged
caalador merged 1 commit into
masterfrom
11376-dom-module-id
Jul 19, 2021
Merged

caalador merged 1 commit into
masterfrom
11376-dom-module-id

Conversation

@denis-anisimov

@denis-anisimov denis-anisimov commented Jul 15, 2021 •

Copy link
Copy Markdown
Contributor

fixes #11376

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 1 issue

  1. MINOR AbstractUpdateImports.java#L294: Remove this method and declare a constant for this value. rule

@caalador
caalador merged commit ccca69d into master Jul 19, 2021
@caalador
caalador deleted the 11376-dom-module-id branch July 19, 2021 08:00
vaadin-bot added a commit that referenced this pull request Jul 19, 2021
vaadin-bot added a commit that referenced this pull request Jul 19, 2021
vaadin-bot added a commit that referenced this pull request Jul 19, 2021
vaadin-bot added a commit that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate dom-module element ids

3 participants