Skip to content

fix: Reuse existing filesystem - #11428

Merged
caalador merged 1 commit into
masterfrom
issues/11378_existing_outside_filesystem
Jul 19, 2021
Merged

caalador merged 1 commit into
masterfrom
issues/11378_existing_outside_filesystem

Conversation

@caalador

Copy link
Copy Markdown
Contributor

When getting a for Flow new FileSystem
there is the possibility that a filesystem
has been created elsewhere. Reuse the
existing FileSystem if it exists.

Fixes #11378

When getting a for Flow new FileSystem
there is the possibility that a filesystem
has been created elsewhere. Reuse the
existing FileSystem if it exists.

Fixes #11378
@caalador
caalador force-pushed the issues/11378_existing_outside_filesystem branch from 67b83fa to 3112916 Compare July 19, 2021 07:11
@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 3 issues

  1. MAJOR StaticFileServer.java#L161: Replace this with a call to the "toFile().isDirectory()" method rule
  2. MAJOR StaticFileServer.java#L171: Replace this with a call to the "toFile().isDirectory()" method rule
  3. MINOR StaticFileServer.java#L212: Move the "file" string literal on the left side of this string comparison. rule

@caalador
caalador merged commit dd6ff5d into master Jul 19, 2021
@caalador
caalador deleted the issues/11378_existing_outside_filesystem branch July 19, 2021 08:39
vaadin-bot pushed a commit that referenced this pull request Jul 19, 2021
When getting a for Flow new FileSystem
there is the possibility that a filesystem
has been created elsewhere. Reuse the
existing FileSystem if it exists.

Fixes #11378
vaadin-bot pushed a commit that referenced this pull request Jul 19, 2021
When getting a for Flow new FileSystem
there is the possibility that a filesystem
has been created elsewhere. Reuse the
existing FileSystem if it exists.

Fixes #11378
vaadin-bot pushed a commit that referenced this pull request Jul 19, 2021
When getting a for Flow new FileSystem
there is the possibility that a filesystem
has been created elsewhere. Reuse the
existing FileSystem if it exists.

Fixes #11378
vaadin-bot pushed a commit that referenced this pull request Jul 19, 2021
When getting a for Flow new FileSystem
there is the possibility that a filesystem
has been created elsewhere. Reuse the
existing FileSystem if it exists.

Fixes #11378
vaadin-bot added a commit that referenced this pull request Jul 19, 2021
When getting a for Flow new FileSystem
there is the possibility that a filesystem
has been created elsewhere. Reuse the
existing FileSystem if it exists.

Fixes #11378

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jul 19, 2021
When getting a for Flow new FileSystem
there is the possibility that a filesystem
has been created elsewhere. Reuse the
existing FileSystem if it exists.

Fixes #11378

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jul 19, 2021
When getting a for Flow new FileSystem
there is the possibility that a filesystem
has been created elsewhere. Reuse the
existing FileSystem if it exists.

Fixes #11378

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jul 19, 2021
When getting a for Flow new FileSystem
there is the possibility that a filesystem
has been created elsewhere. Reuse the
existing FileSystem if it exists.

Fixes #11378

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
Ansku added a commit to vaadin/framework that referenced this pull request Jul 21, 2021
Ansku added a commit to vaadin/framework that referenced this pull request Jul 22, 2021
Ansku added a commit to vaadin/framework that referenced this pull request Aug 6, 2021
TatuLund pushed a commit to vaadin/framework that referenced this pull request Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

14.6 breaks if a ZipFileSystemProvider has been initialized before Vaadin serves a static file from the jar.

3 participants