Skip to content

fix: don't fire shortcut event if ancestor of component is not visible - #11565

Merged
mshabarov merged 3 commits into
masterfrom
7033-shortcut-invisible
Aug 16, 2021
Merged

mshabarov merged 3 commits into
masterfrom
7033-shortcut-invisible

Conversation

@denis-anisimov

@denis-anisimov denis-anisimov commented Aug 12, 2021 •

Copy link
Copy Markdown
Contributor

fixes #7033

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

mshabarov
mshabarov previously approved these changes Aug 16, 2021
@CLAassistant

CLAassistant commented Aug 16, 2021 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

mshabarov
mshabarov previously approved these changes Aug 16, 2021
@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 1 issue

  1. MAJOR ShortcutRegistration.java#L91: Reduce this lambda expression number of lines from 21 to at most 20. rule

@mshabarov
mshabarov enabled auto-merge (squash) August 16, 2021 09:19
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Aug 16, 2021
@mshabarov mshabarov added +0.0.1 and removed +1.0.0 labels Aug 16, 2021
@mshabarov

Copy link
Copy Markdown
Contributor

@denis-anisimov please re-sign the CLA.

@mshabarov
mshabarov merged commit 3c7dd42 into master Aug 16, 2021
@mshabarov
mshabarov deleted the 7033-shortcut-invisible branch August 16, 2021 10:30
vaadin-bot added a commit that referenced this pull request Aug 16, 2021
vaadin-bot added a commit that referenced this pull request Aug 16, 2021
vaadin-bot added a commit that referenced this pull request Aug 16, 2021
vaadin-bot added a commit that referenced this pull request Aug 16, 2021
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shortcut events triggered although lifecycleOwner's parent is not visible

4 participants