Skip to content

chore!: move fusion frontend code to npm packages - #11644

Merged
haijian-vaadin merged 15 commits into
masterfrom
use-fusion-package
Sep 17, 2021
Merged

haijian-vaadin merged 15 commits into
masterfrom
use-fusion-package

Conversation

@haijian-vaadin

@haijian-vaadin haijian-vaadin commented Aug 25, 2021 •

Copy link
Copy Markdown
Contributor

Description

  • Remove the Fusion frontend code from the Flow repo.
  • The flow-server now only depends on the @vaadin/common-frontend package instead of the whole fusion frontend.
  • The Fusion frontend dependencies are added via @NpmPackage in FusionController.
  • It is a breaking change, user would need to update the Fusion specific imports from import {xxx} from @vaadin/flow-frontend to import {xxx} from @vaadin/fusion-frontend.

Fixes vaadin/hilla#28

Type of change

  • Bugfix
  • Feature
  • Refactor

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@haijian-vaadin haijian-vaadin added the hilla Issues related to Hilla label Aug 25, 2021
@haijian-vaadin
haijian-vaadin marked this pull request as ready for review September 15, 2021 17:14
@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 8 issues

  1. MAJOR UI.java#L1014: Call "Optional#isPresent()" before accessing the value. rule
  2. MAJOR TaskUpdatePackages.java#L86: Constructor has 8 parameters, which is greater than 7 authorized. rule
  3. MAJOR TaskUpdatePackages.java#L163: Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed. rule
  4. MAJOR TaskUpdatePackages.java#L215: Take the required action to fix the issue indicated by this comment. rule
  5. MINOR UI.java#L1003: Remove the declaration of thrown exception 'java.lang.IllegalArgumentException' which is a runtime exception. rule
  6. MINOR FusionController.java#L197: Remove this use of "APPLICATION_JSON_UTF8_VALUE"; it is deprecated. rule
  7. INFO UI.java#L968: Do not forget to remove this deprecated code someday. rule
  8. INFO FrontendUtils.java#L160: Do not forget to remove this deprecated code someday. rule

@haijian-vaadin
haijian-vaadin merged commit eaa8075 into master Sep 17, 2021
@haijian-vaadin
haijian-vaadin deleted the use-fusion-package branch September 17, 2021 15:58
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha5 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the new client-side packages

3 participants