Skip to content

fix: remove detach listeners from listenOn components on detach owner - #11956

Merged
caalador merged 4 commits into
masterfrom
11939-shortcut-memory-leak
Oct 1, 2021
Merged

caalador merged 4 commits into
masterfrom
11939-shortcut-memory-leak

Conversation

@denis-anisimov

@denis-anisimov denis-anisimov commented Sep 30, 2021 •

Copy link
Copy Markdown
Contributor

fixes #11939

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Denis and others added 3 commits October 1, 2021 12:28
…gistration.java

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
…gistration.java

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
…gistrationTest.java

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 1 issue

  1. MAJOR ShortcutRegistration.java#L91: Reduce this lambda expression number of lines from 23 to at most 20. rule

@caalador
caalador merged commit b99a029 into master Oct 1, 2021
@caalador
caalador deleted the 11939-shortcut-memory-leak branch October 1, 2021 11:27
vaadin-bot added a commit that referenced this pull request Oct 1, 2021
vaadin-bot added a commit that referenced this pull request Oct 1, 2021
vaadin-bot added a commit that referenced this pull request Oct 1, 2021
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha6 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory leak: button's ShortcutRegistration is not removed after detach

3 participants