Skip to content

fix: return immidiately if VaadinSession is not initialized - #11974

Merged
caalador merged 2 commits into
masterfrom
11961-skip-not-initialized-session
Oct 5, 2021
Merged

caalador merged 2 commits into
masterfrom
11961-skip-not-initialized-session

Conversation

@denis-anisimov

@denis-anisimov denis-anisimov commented Oct 4, 2021 •

Copy link
Copy Markdown
Contributor

fixes #11961

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 3 issues

  1. MAJOR VaadinSession.java#L210: This block of commented-out lines of code should be removed. rule
  2. MAJOR VaadinSession.java#L1077: Make the "java.util.Map" class "Serializable" or don't write it. rule
  3. INFO VaadinSession.java#L79: Do not forget to remove this deprecated code someday. rule

@caalador
caalador enabled auto-merge (squash) October 5, 2021 06:54
@caalador
caalador merged commit a7aac4b into master Oct 5, 2021
@caalador
caalador deleted the 11961-skip-not-initialized-session branch October 5, 2021 08:08
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @denis-anisimov and @caalador, when i performed cherry-pick to this commit to 8.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a7aac4b
error: could not apply a7aac4b... fix: return immidiately if VaadinSession is not initialized (#11974)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @denis-anisimov and @caalador, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a7aac4b
error: could not apply a7aac4b... fix: return immidiately if VaadinSession is not initialized (#11974)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @denis-anisimov and @caalador, when i performed cherry-pick to this commit to 7.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a7aac4b
error: could not apply a7aac4b... fix: return immidiately if VaadinSession is not initialized (#11974)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPE Exception in Development Mode on Startup (Random)

3 participants